components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc - Issue 2363913003: Add FMP to DataReductionProxy UMA and to Pingback Metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc

Issue 2363913003: Add FMP to DataReductionProxy UMA and to Pingback Metrics (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.h ('k') | components/data_reduction_proxy/proto/pageload_metrics.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc

diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc b/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc

index b7357d0081ae496fad29b210621634ad9638ae5a..a5ed2e43856137766c8b96918e76416394891ad1 100644

--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc

+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc

@@ -5,26 +5,28 @@

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.h"

namespace data_reduction_proxy {

DataReductionProxyPageLoadTiming::DataReductionProxyPageLoadTiming(

const base::Time& navigation_start,

const base::Optional<base::TimeDelta>& response_start,

const base::Optional<base::TimeDelta>& load_event_start,

const base::Optional<base::TimeDelta>& first_image_paint,

const base::Optional<base::TimeDelta>& first_contentful_paint,

+ const base::Optional<base::TimeDelta>& experimental_first_meaningful_paint,

const base::Optional<base::TimeDelta>&

parse_blocked_on_script_load_duration,

const base::Optional<base::TimeDelta>& parse_stop)

: navigation_start(navigation_start),

response_start(response_start),

load_event_start(load_event_start),

first_image_paint(first_image_paint),

first_contentful_paint(first_contentful_paint),

+ experimental_first_meaningful_paint(experimental_first_meaningful_paint),

parse_blocked_on_script_load_duration(

parse_blocked_on_script_load_duration),

parse_stop(parse_stop) {}

DataReductionProxyPageLoadTiming::DataReductionProxyPageLoadTiming(

const DataReductionProxyPageLoadTiming& other) = default;

} // namespace data_reduction_proxy