Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2363873002: Json ide script for gn to output cmake. (Closed)

Created:
4 years, 3 months ago by bungeman-skia
Modified:
4 years, 3 months ago
Reviewers:
herb_g, bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Json ide script for gn to output cmake. Can be run like gn gen out/debug --ide=json --json-ide-script=../../gn/gn_to_cmake.py or gn gen out/debug --ide=json python gn/gn_to_cmake.py out/debug/project.json This first pass creates CMakeLists.txt with just enough information for an ide. Each target is just a static library with sources, include directories, and defines. NOTRY=true This isn't automatically tested. Committed: https://skia.googlesource.com/skia/+/623ef92e4fd7d79786f828844aade96bc3578e0e

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -0 lines) Patch
A gn/gn_to_cmake.py View 1 1 chunk +110 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
bungeman-skia
Try it out, see if it's good enough for now (this is pretty much how ...
4 years, 3 months ago (2016-09-22 22:09:11 UTC) #4
herb_g
https://codereview.chromium.org/2363873002/diff/1/gn/gn_to_cmake.py File gn/gn_to_cmake.py (right): https://codereview.chromium.org/2363873002/diff/1/gn/gn_to_cmake.py#newcode7 gn/gn_to_cmake.py:7: Comment showing typical use.
4 years, 3 months ago (2016-09-23 14:41:22 UTC) #5
herb_g
lgtm
4 years, 3 months ago (2016-09-23 14:41:29 UTC) #6
bungeman-skia
https://codereview.chromium.org/2363873002/diff/1/gn/gn_to_cmake.py File gn/gn_to_cmake.py (right): https://codereview.chromium.org/2363873002/diff/1/gn/gn_to_cmake.py#newcode7 gn/gn_to_cmake.py:7: On 2016/09/23 14:41:21, herb_g wrote: > Comment showing typical ...
4 years, 3 months ago (2016-09-23 15:12:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363873002/20001
4 years, 3 months ago (2016-09-23 15:14:51 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 15:16:06 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/623ef92e4fd7d79786f828844aade96bc3578e0e

Powered by Google App Engine
This is Rietveld 408576698