[Sync] Test that MergeSyncData is not called on subsequent starts.

[Sync] Test that MergeSyncData is not called on subsequent starts.

BUG=

Committed: https://crrev.com/4d75c8290f9d7b913cda62f003809b12c725264e
Cr-Commit-Position: refs/heads/master@{#420723}

[maxbogue, 2016-09-22 21:29:47]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[maxbogue, 2016-09-22 21:30:15]

maxbogue@chromium.org changed reviewers:
+ pavely@chromium.org

[maxbogue, 2016-09-22 21:30:16]

Pavel, PTAL!

[commit-bot: I haz the power, 2016-09-22 21:30:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 22:03:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 22:03:13]

Dry run: This issue passed the CQ dry run.

[pavely, 2016-09-23 18:03:03]

lgtm

https://codereview.chromium.org/2363853002/diff/1/components/sync/core/shared...
File components/sync/core/shared_model_type_processor_unittest.cc (right):

https://codereview.chromium.org/2363853002/diff/1/components/sync/core/shared...
components/sync/core/shared_model_type_processor_unittest.cc:343:
OnInitialSyncDone(kKey2, kValue2);
I think OnInitialSyncDone is misleading name in this test. You already call
InitializeToMetadataLoaded() at the beginning, which should set
initial_sync_done flag. This call is only to simulate valid GetUpdates response.

[maxbogue, 2016-09-23 18:57:51]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 18:58:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-09-23 18:59:39]

https://codereview.chromium.org/2363853002/diff/1/components/sync/core/shared...
File components/sync/core/shared_model_type_processor_unittest.cc (right):

https://codereview.chromium.org/2363853002/diff/1/components/sync/core/shared...
components/sync/core/shared_model_type_processor_unittest.cc:343:
OnInitialSyncDone(kKey2, kValue2);
On 2016/09/23 18:03:03, pavely wrote:
> I think OnInitialSyncDone is misleading name in this test. You already call
> InitializeToMetadataLoaded() at the beginning, which should set
> initial_sync_done flag. This call is only to simulate valid GetUpdates
response.

Good point! I've removed OnInitialSyncDone entirely in favor of calling
worker()->UpdateFromServer().

[pavely, 2016-09-23 19:03:20]

lgtm

[commit-bot: I haz the power, 2016-09-23 19:46:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 19:46:46]

Dry run: This issue passed the CQ dry run.

[maxbogue, 2016-09-23 20:51:33]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-09-23 20:52:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 20:58:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-23 21:00:14]

Description was changed from

==========
[Sync] Test that MergeSyncData is not called on subsequent starts.

BUG=
==========

to

==========
[Sync] Test that MergeSyncData is not called on subsequent starts.

BUG=

Committed: https://crrev.com/4d75c8290f9d7b913cda62f003809b12c725264e
Cr-Commit-Position: refs/heads/master@{#420723}
==========

[commit-bot: I haz the power, 2016-09-23 21:00:15]

Patchset 2 (id:??) landed as
https://crrev.com/4d75c8290f9d7b913cda62f003809b12c725264e
Cr-Commit-Position: refs/heads/master@{#420723}