chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelAnimation.java - Issue 2363843002: [Contextual Search] Animate thumbnail appearance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelAnimation.java

Issue 2363843002: [Contextual Search] Animate thumbnail appearance (Closed)

Patch Set: Changes from donnd@ review Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchIconSpriteControl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelAnimation.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelAnimation.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelAnimation.java

index 132d85eb51dc00d7b048a66c9c115eeb0285328d..e052ae4ffae674a52c5d3c1b8340119af656222c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelAnimation.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelAnimation.java

@@ -457,7 +457,7 @@ public abstract class OverlayPanelAnimation extends OverlayPanelBase

* @param setStartValueAfterDelay See {@link Animation#setStartValueAfterStartDelay(boolean)}

* @param interpolator The interpolator to use for the animation

- protected <T extends Enum<?>> void addToAnimation(Animatable<T> object, T prop, float start,

+ public <T extends Enum<?>> void addToAnimation(Animatable<T> object, T prop, float start,

float end, long duration, long startTime, boolean setStartValueAfterDelay,

Interpolator interpolator) {

ChromeAnimation.Animation<Animatable<?>> component = createAnimation(object, prop, start,