chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java - Issue 2363843002: [Contextual Search] Animate thumbnail appearance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

Issue 2363843002: [Contextual Search] Animate thumbnail appearance (Closed)

Patch Set: [Contextual Search] Animate thumbnail appearance Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchImageControl.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java ('k') | chrome/android/java_sources.gni » ('j') | chrome/browser/android/compositor/layer/contextual_search_layer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

index 3d3f3e59a6a7a2feed77a313d45a499ca661957c..6e8b1c4d30cac6c6c5ea3ef93c76bc17e95ebb6f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

@@ -480,7 +480,8 @@ public class ContextualSearchManager implements ContextualSearchManagementDelega

// Note: whether the sprite should be animated or not needs to be set before the call to

// peekPanel(). If the sprite should be animated, the animation will begin after the panel

// finishes peeking. If it should not be animated, the icon will be drawn right away.

- mSearchPanel.setShouldAnimateIconSprite(mPolicy.shouldAnimateSearchProviderIcon());

+ mSearchPanel.getImageControl().setShouldAnimateIconSprite(

+ mPolicy.shouldAnimateSearchProviderIcon());

// Note: now that the contextual search has properly started, set the promo involvement.

if (mPolicy.isPromoAvailable()) {