third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h - Issue 2363833003: FATAL:DCHECK failed on BreakingContext::rewindToMidWordBreak()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

Issue 2363833003: FATAL:DCHECK failed on BreakingContext::rewindToMidWordBreak() (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/text/breaking-context-inline-crash.html ('K') | « third_party/WebKit/LayoutTests/fast/text/breaking-context-inline-crash.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

diff --git a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

index c8f2fc65a6464cb5c05d6c2939e0843005a2401c..9cde5d58158f673e3af0edcad3b6920f576e8eab 100644

--- a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

+++ b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

@@ -1006,6 +1006,8 @@ inline bool BreakingContext::handleText(WordMeasurements& wordMeasurements, bool

hyphenated = true;

m_atEnd = true;

}

+ if (!m_ignoringSpaces && canBreakMidWord)

kojii 2016/09/27 07:51:01 Probably this can be "else if"?

+ m_atEnd = true;

}

return false;

}