Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2363833002: Expand the list of devices that require a GPU workaround. (Closed)

Created:
4 years, 3 months ago by erikchen
Modified:
4 years, 3 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expand the list of devices that require a GPU workaround. Old AMD devices are known to require a workaround for colormasks on multisample renderbuffers. This CL expands the list of devices known to need this workaround. BUG=648466 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/e9a527e058e65fcbfc37b817a5ef7e6693fbb209 Cr-Commit-Position: refs/heads/master@{#420756}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments from kbr. #

Patch Set 3 : REbase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 34 (18 generated)
erikchen
kbr: Please review.
4 years, 3 months ago (2016-09-22 20:29:19 UTC) #4
Ken Russell (switch to Gerrit)
Awesome, thank you. LGTM Once this lands could you propose a merge to M54? I'd ...
4 years, 3 months ago (2016-09-23 00:28:10 UTC) #8
erikchen
https://codereview.chromium.org/2363833002/diff/1/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2363833002/diff/1/gpu/config/gpu_driver_bug_list_json.cc#newcode22 gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.99", On 2016/09/23 00:28:10, Ken Russell wrote: > ...
4 years, 3 months ago (2016-09-23 00:58:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363833002/20001
4 years, 3 months ago (2016-09-23 00:59:13 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/146755)
4 years, 3 months ago (2016-09-23 03:07:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363833002/20001
4 years, 3 months ago (2016-09-23 15:50:41 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/147087)
4 years, 3 months ago (2016-09-23 15:57:31 UTC) #18
Ken Russell (switch to Gerrit)
On 2016/09/23 15:57:31, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 3 months ago (2016-09-23 17:31:36 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363833002/40001
4 years, 3 months ago (2016-09-23 17:37:41 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/3978)
4 years, 3 months ago (2016-09-23 17:57:38 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363833002/40001
4 years, 3 months ago (2016-09-23 18:11:08 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/3982)
4 years, 3 months ago (2016-09-23 19:21:02 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363833002/40001
4 years, 3 months ago (2016-09-23 19:36:28 UTC) #30
Ken Russell (switch to Gerrit)
On 2016/09/23 19:21:02, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 3 months ago (2016-09-23 19:37:00 UTC) #31
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-23 22:46:48 UTC) #32
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 22:50:54 UTC) #34
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e9a527e058e65fcbfc37b817a5ef7e6693fbb209
Cr-Commit-Position: refs/heads/master@{#420756}

Powered by Google App Engine
This is Rietveld 408576698