|
|
Created:
4 years, 3 months ago by erikchen Modified:
4 years, 3 months ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionExpand the list of devices that require a GPU workaround.
Old AMD devices are known to require a workaround for colormasks on multisample
renderbuffers. This CL expands the list of devices known to need this
workaround.
BUG=648466
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/e9a527e058e65fcbfc37b817a5ef7e6693fbb209
Cr-Commit-Position: refs/heads/master@{#420756}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Comments from kbr. #Patch Set 3 : REbase. #Messages
Total messages: 34 (18 generated)
Description was changed from ========== Expand the list of devices that require a GPU workaround. Old AMD devices are known to require a workaround for colormasks on multisample renderbuffers. This CL expands the list of devices known to need this workaround. BUG=648466 ========== to ========== Expand the list of devices that require a GPU workaround. Old AMD devices are known to require a workaround for colormasks on multisample renderbuffers. This CL expands the list of devices known to need this workaround. BUG=648466 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
erikchen@chromium.org changed reviewers: + kbr@chromium.org
kbr: Please review.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Awesome, thank you. LGTM Once this lands could you propose a merge to M54? I'd forgotten that this control existed. Unfortunately, the merge will have to be done by hand because of the need to update the version number on the branch. https://codereview.chromium.org/2363833002/diff/1/gpu/config/gpu_driver_bug_l... File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2363833002/diff/1/gpu/config/gpu_driver_bug_l... gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.99", Please update the version.
https://codereview.chromium.org/2363833002/diff/1/gpu/config/gpu_driver_bug_l... File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2363833002/diff/1/gpu/config/gpu_driver_bug_l... gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.99", On 2016/09/23 00:28:10, Ken Russell wrote: > Please update the version. Done.
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org Link to the patchset: https://codereview.chromium.org/2363833002/#ps20001 (title: "Comments from kbr.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
On 2016/09/23 15:57:31, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, > https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) Gee, there have been a lot of rapid updates to this file recently. Sorry. Could you rebase one more time?
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org Link to the patchset: https://codereview.chromium.org/2363833002/#ps40001 (title: "REbase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/09/23 19:21:02, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...) Sorry about this flakiness. Reported it in http://crbug.com/626862 .
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Expand the list of devices that require a GPU workaround. Old AMD devices are known to require a workaround for colormasks on multisample renderbuffers. This CL expands the list of devices known to need this workaround. BUG=648466 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Expand the list of devices that require a GPU workaround. Old AMD devices are known to require a workaround for colormasks on multisample renderbuffers. This CL expands the list of devices known to need this workaround. BUG=648466 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/e9a527e058e65fcbfc37b817a5ef7e6693fbb209 Cr-Commit-Position: refs/heads/master@{#420756} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/e9a527e058e65fcbfc37b817a5ef7e6693fbb209 Cr-Commit-Position: refs/heads/master@{#420756} |