Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2363813002: Clear pause timer upon start of a playback. (Closed)

Created:
4 years, 3 months ago by DaleCurtis
Modified:
4 years, 3 months ago
Reviewers:
watk
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear pause timer upon start of a playback. Otherwise this may nuke intentional playbacks from the media session. BUG=649271 TEST=playback doesn't pause after 5 seconds if play occurs. Committed: https://crrev.com/4619cd0ee861c0e15e0ed49e99f633f01b96fbdd Cr-Commit-Position: refs/heads/master@{#420468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/blink/webmediaplayer_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
DaleCurtis
4 years, 3 months ago (2016-09-22 19:19:43 UTC) #2
watk
lgtm
4 years, 3 months ago (2016-09-22 19:24:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363813002/1
4 years, 3 months ago (2016-09-22 19:53:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 21:39:39 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 21:42:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4619cd0ee861c0e15e0ed49e99f633f01b96fbdd
Cr-Commit-Position: refs/heads/master@{#420468}

Powered by Google App Engine
This is Rietveld 408576698