Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: typ/tests/runner_test.py

Issue 2363773008: Add better logging when failing to load a test. (Closed)
Patch Set: patch for review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« typ/tests/main_test.py ('K') | « typ/tests/main_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: typ/tests/runner_test.py
diff --git a/typ/tests/runner_test.py b/typ/tests/runner_test.py
index 95831495647ddfe14be7f2211fa7245d4367b7a7..4ebb30b24493997b37c1b583a49c67c24533781f 100644
--- a/typ/tests/runner_test.py
+++ b/typ/tests/runner_test.py
@@ -98,8 +98,11 @@ class TestSetTests(TestCase):
test_set.parallel_tests = [TestInput('load_test.BaseTest.test_x')]
r = Runner()
r.args.jobs = 1
- ret, _, _ = r.run(test_set)
+ ret, _, trace = r.run(test_set)
self.assertEqual(ret, 1)
+ self.assertIn('Failed to load "load_test.BaseTest.test_x" in '
+ 'run_one_test',
+ trace['traceEvents'][0]['args']['err'])
finally:
h.chdir(orig_wd)
if tmpdir:
« typ/tests/main_test.py ('K') | « typ/tests/main_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698