Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2363773005: Move closed world reasoning methods from ClassWorld to ClosedWorld. (Closed)

Created:
4 years, 3 months ago by Johnni Winther
Modified:
4 years, 2 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move closed world reasoning methods from ClassWorld to ClosedWorld. Main changes in world.dart R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/8820b8046b86d77767b32b2bd37069fd0ea4a6b9

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+572 lines, -540 lines) Patch
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 12 chunks +21 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/field_naming_mixin.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/js_interop_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 7 chunks +13 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 5 chunks +13 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 3 chunks +68 lines, -65 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 9 chunks +18 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/types/flat_type_mask.dart View 26 chunks +144 lines, -144 lines 0 comments Download
M pkg/compiler/lib/src/types/masks.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/types/type_mask.dart View 7 chunks +63 lines, -63 lines 0 comments Download
M pkg/compiler/lib/src/types/union_type_mask.dart View 12 chunks +61 lines, -61 lines 0 comments Download
M pkg/compiler/lib/src/universe/function_set.dart View 11 chunks +29 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 25 chunks +65 lines, -37 lines 2 comments Download
M tests/compiler/dart2js/jsinterop/world_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/related_types.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_mask2_test.dart View 9 chunks +33 lines, -33 lines 0 comments Download
M tests/compiler/dart2js/world_test.dart View 4 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Johnni Winther
4 years, 3 months ago (2016-09-23 11:50:58 UTC) #3
Harry Terkelsen
lgtm https://codereview.chromium.org/2363773005/diff/1/pkg/compiler/lib/src/world.dart File pkg/compiler/lib/src/world.dart (right): https://codereview.chromium.org/2363773005/diff/1/pkg/compiler/lib/src/world.dart#newcode54 pkg/compiler/lib/src/world.dart:54: String dump([ClassElement cls]); @OnlyForTesting? Or whatever the annotation ...
4 years, 3 months ago (2016-09-23 17:20:27 UTC) #4
Johnni Winther
Committed patchset #1 (id:1) manually as 8820b8046b86d77767b32b2bd37069fd0ea4a6b9 (presubmit successful).
4 years, 2 months ago (2016-09-26 09:15:08 UTC) #6
Johnni Winther
4 years, 2 months ago (2016-09-26 14:02:48 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/2363773005/diff/1/pkg/compiler/lib/src/world....
File pkg/compiler/lib/src/world.dart (right):

https://codereview.chromium.org/2363773005/diff/1/pkg/compiler/lib/src/world....
pkg/compiler/lib/src/world.dart:54: String dump([ClassElement cls]);
On 2016/09/23 17:20:27, Harry Terkelsen wrote:
> @OnlyForTesting? Or whatever the annotation is?

Haven't heard of it. Can you find its exactly location?

Powered by Google App Engine
This is Rietveld 408576698