Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2363773003: [d8/modules] Factor out path and string handling logic (Closed)

Created:
4 years, 3 months ago by adamk
Modified:
4 years, 3 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[d8/modules] Factor out path and string handling logic Also canonicalize all path separators to '/' for simplicity. Committed: https://crrev.com/1ca44a0a28d953ad71ff103da6c1bdd7e4d0d15d Cr-Commit-Position: refs/heads/master@{#39648}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -26 lines) Patch
M src/d8.cc View 6 chunks +25 lines, -26 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
adamk
4 years, 3 months ago (2016-09-22 23:32:55 UTC) #2
neis
lgtm
4 years, 3 months ago (2016-09-23 00:30:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363773003/1
4 years, 3 months ago (2016-09-23 00:32:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 00:35:02 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 00:35:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ca44a0a28d953ad71ff103da6c1bdd7e4d0d15d
Cr-Commit-Position: refs/heads/master@{#39648}

Powered by Google App Engine
This is Rietveld 408576698