[NTP Snippets] Don't reschedule background fetching on every startup

chrome/browser/android/ntp/ntp_snippets_bridge.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/ntp/ntp_snippets_bridge.h"
 
 #include <jni.h>
 
 #include "base/android/callback_android.h"
 #include "base/android/jni_android.h"
@@ skipping 74 matching lines @@
       content_suggestions_service->ntp_snippets_service();
 
   // Can be null if the feature has been disabled but the scheduler has not been
   // unregistered yet. The next start should unregister it.
   if (!service)
     return;
 
   service->FetchSnippets(j_force_request);
 }
 
 // Reschedules the fetching of snippets.

[jkrcal, 2016/09/23 10:28:34]

Maybe expanding the comment? That it does forced rescheduling, where it is
supposed to be called from, etc.

[Marc Treib, 2016/09/23 11:19:13]

I added the "forced" part. IMO where it is supposed to be called from isn't good
to mention in a comment, it's bound to get out of date.

[jkrcal, 2016/09/23 11:24:53]

Acknowledged.

 static void RescheduleFetching(JNIEnv* env,
                                const JavaParamRef<jclass>& caller) {
   Profile* profile = ProfileManager::GetLastUsedProfile();
   // Temporary check while investigating crbug.com/647920.
   CHECK(profile);
 
   ntp_snippets::ContentSuggestionsService* content_suggestions_service =
       ContentSuggestionsServiceFactory::GetForProfile(profile);
 
   // Can maybe be null in some cases? (Incognito profile?) crbug.com/647920
   if (!content_suggestions_service)
     return;
 
   ntp_snippets::NTPSnippetsService* service =
       content_suggestions_service->ntp_snippets_service();
 
   // Can be null if the feature has been disabled but the scheduler has not been
   // unregistered yet. The next start should unregister it.
   if (!service)
     return;
 
-  service->RescheduleFetching();
+  service->RescheduleFetching(/*force=*/true);
 }
 
 static void OnSuggestionTargetVisited(JNIEnv* env,
                                       const JavaParamRef<jclass>& caller,
                                       jint category,
                                       jlong visit_time_ms) {
   Profile* profile = ProfileManager::GetLastUsedProfile();
   ntp_snippets::ContentSuggestionsService* content_suggestions_service =
       ContentSuggestionsServiceFactory::GetForProfile(profile);
   ntp_snippets::metrics::OnSuggestionTargetVisited(
@@ skipping 254 matching lines @@
 }
 
 Category NTPSnippetsBridge::CategoryFromIDValue(jint id) {
   return content_suggestions_service_->category_factory()->FromIDValue(id);
 }
 
 // static
 bool NTPSnippetsBridge::Register(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }