Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2363743006:
Remove redundant copy constructor for NGPhysicalConstraintSpace (Closed)
|
Created:
4 years, 3 months ago by Gleb Lanbin Modified:
4 years, 2 months ago CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove redundant copy constructor for NGPhysicalConstraintSpace
The existing NGPhysicalConstraintSpace's copy constructor doesn't copy container_size_. This causes some bugs.
C++ compiler provides a copy constructor by default. Lets remove the redundant one.
BUG=635619
Committed: https://crrev.com/5ab0ea957e8f988b50bd224a08c3503c146b7ab7
Cr-Commit-Position: refs/heads/master@{#422306}
Patch Set 1 #
Messages
Total messages: 22 (12 generated)
Description was changed from ========== fix BUG=635619 ========== to ========== Remove redundant copy constructor for NGPhysicalConstraintSpace The existing NGPhysicalConstraintSpace's copy constructor doesn't copy container_size_. This causes some bugs. C++ compiler provides a copy constructor by default. Lets remove the redundant one. BUG=635619 ==========
glebl@chromium.org changed reviewers: + cbiesinger@chromium.org
The CQ bit was checked by glebl@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
cbiesinger@chromium.org changed reviewers: + eae@chromium.org
Adding eae, because if I recall correctly it purposefully does not copy exclusions, so a manual constructor may still be required (but the missing container size seems like a bug) Where do we use this constructor?
On 2016/09/23 18:23:49, cbiesinger wrote: > Adding eae, because if I recall correctly it purposefully does not copy > exclusions, so a manual constructor may still be required (but the missing > container size seems like a bug) > > Where do we use this constructor? this constructor is not used at this moment. I tried to use it while working on an experimental patch that minimizes the usage of Oilpan in LayoutNG code and found a container_size_ bug.
We shouldn't really ever have to copy NGPhysicalConstraintSpace objects and instead copy/create new NGConstraintSpace ones that share the same backing NGPhysicalConstraintSpace.
as such, LGTM
The CQ bit was checked by glebl@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by glebl@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove redundant copy constructor for NGPhysicalConstraintSpace The existing NGPhysicalConstraintSpace's copy constructor doesn't copy container_size_. This causes some bugs. C++ compiler provides a copy constructor by default. Lets remove the redundant one. BUG=635619 ========== to ========== Remove redundant copy constructor for NGPhysicalConstraintSpace The existing NGPhysicalConstraintSpace's copy constructor doesn't copy container_size_. This causes some bugs. C++ compiler provides a copy constructor by default. Lets remove the redundant one. BUG=635619 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove redundant copy constructor for NGPhysicalConstraintSpace The existing NGPhysicalConstraintSpace's copy constructor doesn't copy container_size_. This causes some bugs. C++ compiler provides a copy constructor by default. Lets remove the redundant one. BUG=635619 ========== to ========== Remove redundant copy constructor for NGPhysicalConstraintSpace The existing NGPhysicalConstraintSpace's copy constructor doesn't copy container_size_. This causes some bugs. C++ compiler provides a copy constructor by default. Lets remove the redundant one. BUG=635619 Committed: https://crrev.com/5ab0ea957e8f988b50bd224a08c3503c146b7ab7 Cr-Commit-Position: refs/heads/master@{#422306} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5ab0ea957e8f988b50bd224a08c3503c146b7ab7 Cr-Commit-Position: refs/heads/master@{#422306} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
