Non-functional optimization to Android NetworkChangeNotifier startup part 2

Non-functional optimization to Android NetworkChangeNotifier startup part 2

Avoid needlessly computing whether a change signal needs to be sent out during
initialization (when there can't be a change).  This allows avoiding
needlessly requerying the current connection state.

BUG=647691
R=xunjieli

Committed: https://crrev.com/077c5724607adaa7fcc6ca04cdf5975133560eb0
Cr-Commit-Position: refs/heads/master@{#422357}

[pauljensen, 2016-09-22 15:29:52]

Helen, PTAL, thank you! This is the fifth in the breakup of the bigger NCN
speed-up CL.

[xunjieli, 2016-09-30 17:23:38]

LGTM

https://codereview.chromium.org/2363743002/diff/1/net/android/java/src/org/ch...
File net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java
(right):

https://codereview.chromium.org/2363743002/diff/1/net/android/java/src/org/ch...
net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java:547:
private boolean mSignal;
Maybe use a more verbose name like mShouldSignalObserver so it is slightly more
descriptive?

https://codereview.chromium.org/2363743002/diff/1/net/android/java/src/org/ch...
net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java:667:
public void register() {
Not sure if it's worth adding a "ThreadUtils.assertOnUiThread()" here, but it
might make the mSignal variable access clearer.

[pauljensen, 2016-10-03 00:35:15]

https://codereview.chromium.org/2363743002/diff/1/net/android/java/src/org/ch...
File net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java
(right):

https://codereview.chromium.org/2363743002/diff/1/net/android/java/src/org/ch...
net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java:547:
private boolean mSignal;
On 2016/09/30 17:23:37, xunjieli wrote:
> Maybe use a more verbose name like mShouldSignalObserver so it is slightly
more
> descriptive? 

Done.

https://codereview.chromium.org/2363743002/diff/1/net/android/java/src/org/ch...
net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java:667:
public void register() {
On 2016/09/30 17:23:37, xunjieli wrote:
> Not sure if it's worth adding a "ThreadUtils.assertOnUiThread()" here, but it
> might make the mSignal variable access clearer. 

Done.

[pauljensen, 2016-10-03 00:57:26]

The CQ bit was checked by pauljensen@chromium.org

[pauljensen, 2016-10-03 00:57:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
xunjieli@chromium.org
Link to the patchset: https://codereview.chromium.org/2363743002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-03 00:57:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 01:29:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-03 01:31:49]

Description was changed from

==========
Non-functional optimization to Android NetworkChangeNotifier startup part 2

Avoid needlessly computing whether a change signal needs to be sent out during
initialization (when there can't be a change).  This allows avoiding
needlessly requerying the current connection state.

BUG=647691
R=xunjieli
==========

to

==========
Non-functional optimization to Android NetworkChangeNotifier startup part 2

Avoid needlessly computing whether a change signal needs to be sent out during
initialization (when there can't be a change).  This allows avoiding
needlessly requerying the current connection state.

BUG=647691
R=xunjieli

Committed: https://crrev.com/077c5724607adaa7fcc6ca04cdf5975133560eb0
Cr-Commit-Position: refs/heads/master@{#422357}
==========

[commit-bot: I haz the power, 2016-10-03 01:31:50]

Patchset 3 (id:??) landed as
https://crrev.com/077c5724607adaa7fcc6ca04cdf5975133560eb0
Cr-Commit-Position: refs/heads/master@{#422357}