Chromium Code Reviews| Index: syzygy/agent/asan/logger_unittest.cc |
| diff --git a/syzygy/agent/asan/logger_unittest.cc b/syzygy/agent/asan/logger_unittest.cc |
| index 446d7e3278bfcda4f39866b746090de1b5043c8c..a94d1ddcb2cb8a835fdd14a56f895aaed02d6c9a 100644 |
| --- a/syzygy/agent/asan/logger_unittest.cc |
| +++ b/syzygy/agent/asan/logger_unittest.cc |
| @@ -125,7 +125,17 @@ TEST_F(AsanLoggerTest, EndToEnd) { |
| using base::FileEnumerator; |
| FileEnumerator fe(temp_dir_.path(), false, FileEnumerator::FILES, L"*.dmp"); |
| base::FilePath minidump(fe.Next()); |
| +#ifndef _WIN64 |
| EXPECT_FALSE(minidump.empty()); |
| +#else |
| + // The 64 bit version of the logger doesn't support writting minidumps yet |
|
chrisha
2016/10/14 19:53:13
writing*
Sébastien Marchand
2016/10/14 20:04:03
Done.
|
| + // because it relies on Kasko, which hasn't been ported to 64-bit. Make sure |
| + // that no PDB get produced until we switch the minidump generation to using |
| + // Crashpad. |
| + // TODO(sebmarchand): Add support for generating minidump to the 64 bit |
|
chrisha
2016/10/14 19:53:13
minidumps* ... 64-bit*
Sébastien Marchand
2016/10/14 20:04:03
Done.
|
| + // version of the logger. |
| + EXPECT_TRUE(minidump.empty()); |
| +#endif |
| EXPECT_TRUE(fe.Next().empty()); |
| // TODO(rogerm): Inspect the contents of the minidump. |