Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: syzygy/agent/asan/logger_unittest.cc

Issue 2363733003: Make syzyasan_rtl compile in 64 bit (Closed)
Patch Set: Bug fixes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: syzygy/agent/asan/logger_unittest.cc
diff --git a/syzygy/agent/asan/logger_unittest.cc b/syzygy/agent/asan/logger_unittest.cc
index 446d7e3278bfcda4f39866b746090de1b5043c8c..472b5f8d772ff58e99ad1a2e928e71be4500f757 100644
--- a/syzygy/agent/asan/logger_unittest.cc
+++ b/syzygy/agent/asan/logger_unittest.cc
@@ -125,7 +125,15 @@ TEST_F(AsanLoggerTest, EndToEnd) {
using base::FileEnumerator;
FileEnumerator fe(temp_dir_.path(), false, FileEnumerator::FILES, L"*.dmp");
base::FilePath minidump(fe.Next());
+#ifndef _WIN64
EXPECT_FALSE(minidump.empty());
+#else
+ // The 64 bit version of the logger doesn't support writting minidumps yet
+ // because it relies on Kasko, which hasn't been ported to 64-bit. Make sure
+ // that no PDB get produced until we switch the minidump generation to using
+ // Crashpad.
chrisha 2016/10/13 20:22:49 Missing TODO(sebmarchand) somewhere here too?
Sébastien Marchand 2016/10/13 21:05:45 Done.
+ EXPECT_TRUE(minidump.empty());
+#endif
EXPECT_TRUE(fe.Next().empty());
// TODO(rogerm): Inspect the contents of the minidump.

Powered by Google App Engine
This is Rietveld 408576698