Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: Source/bindings/v8/custom/V8HistoryCustom.cpp

Issue 23637014: Have V8HiddenPropertyName static functions take an isolate in argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/custom/V8HistoryCustom.cpp
diff --git a/Source/bindings/v8/custom/V8HistoryCustom.cpp b/Source/bindings/v8/custom/V8HistoryCustom.cpp
index 4fa07e015eef3ad186ac07ae40f6a6633fe28905..0300b0c355e5ffdd7afce6298b0c8ef8aea33fc0 100644
--- a/Source/bindings/v8/custom/V8HistoryCustom.cpp
+++ b/Source/bindings/v8/custom/V8HistoryCustom.cpp
@@ -45,7 +45,7 @@ void V8History::stateAttributeGetterCustom(v8::Local<v8::String> name, const v8:
{
History* history = V8History::toNative(info.Holder());
- v8::Handle<v8::Value> value = info.Holder()->GetHiddenValue(V8HiddenPropertyName::state());
+ v8::Handle<v8::Value> value = info.Holder()->GetHiddenValue(V8HiddenPropertyName::state(info.GetIsolate()));
if (!value.IsEmpty() && !history->stateChanged()) {
v8SetReturnValue(info, value);
@@ -54,7 +54,7 @@ void V8History::stateAttributeGetterCustom(v8::Local<v8::String> name, const v8:
RefPtr<SerializedScriptValue> serialized = history->state();
value = serialized ? serialized->deserialize(info.GetIsolate()) : v8::Handle<v8::Value>(v8::Null(info.GetIsolate()));
- info.Holder()->SetHiddenValue(V8HiddenPropertyName::state(), value);
+ info.Holder()->SetHiddenValue(V8HiddenPropertyName::state(info.GetIsolate()), value);
v8SetReturnValue(info, value);
}
@@ -72,7 +72,7 @@ void V8History::pushStateMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&
ExceptionState es(args.GetIsolate());
History* history = V8History::toNative(args.Holder());
history->stateObjectAdded(historyState.release(), title, url, SameDocumentNavigationPushState, es);
- args.Holder()->DeleteHiddenValue(V8HiddenPropertyName::state());
+ args.Holder()->DeleteHiddenValue(V8HiddenPropertyName::state(args.GetIsolate()));
es.throwIfNeeded();
}
@@ -89,7 +89,7 @@ void V8History::replaceStateMethodCustom(const v8::FunctionCallbackInfo<v8::Valu
ExceptionState es(args.GetIsolate());
History* history = V8History::toNative(args.Holder());
history->stateObjectAdded(historyState.release(), title, url, SameDocumentNavigationReplaceState, es);
- args.Holder()->DeleteHiddenValue(V8HiddenPropertyName::state());
+ args.Holder()->DeleteHiddenValue(V8HiddenPropertyName::state(args.GetIsolate()));
es.throwIfNeeded();
}
« no previous file with comments | « Source/bindings/v8/custom/V8ErrorEventCustom.cpp ('k') | Source/bindings/v8/custom/V8MessageEventCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698