Source/bindings/v8/V8MutationCallback.cpp - Issue 23637014: Have V8HiddenPropertyName static functions take an isolate in argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8MutationCallback.cpp

Issue 23637014: Have V8HiddenPropertyName static functions take an isolate in argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8MutationCallback.cpp

diff --git a/Source/bindings/v8/V8MutationCallback.cpp b/Source/bindings/v8/V8MutationCallback.cpp

index 950a95961fff0deac5dc6455bf64c198c6b6d346..bd8733d50325998c965193acff9dfe651b88dbe0 100644

--- a/Source/bindings/v8/V8MutationCallback.cpp

+++ b/Source/bindings/v8/V8MutationCallback.cpp

@@ -42,7 +42,7 @@ V8MutationCallback::V8MutationCallback(v8::Handle<v8::Function> callback, Script

, m_world(DOMWrapperWorld::current())

, m_isolate(isolate)

{

- owner->SetHiddenValue(V8HiddenPropertyName::callback(), callback);

+ owner->SetHiddenValue(V8HiddenPropertyName::callback(m_isolate), callback);

m_callback.makeWeak(this, &makeWeakCallback);

}