Source/bindings/v8/V8HiddenPropertyName.cpp - Issue 23637014: Have V8HiddenPropertyName static functions take an isolate in argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8HiddenPropertyName.cpp

Issue 23637014: Have V8HiddenPropertyName static functions take an isolate in argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8HiddenPropertyName.cpp

diff --git a/Source/bindings/v8/V8HiddenPropertyName.cpp b/Source/bindings/v8/V8HiddenPropertyName.cpp

index 776de512ade033d55defe851919672914413c8da..07a9652f514d81904371d35426c1a63a38a636b5 100644

--- a/Source/bindings/v8/V8HiddenPropertyName.cpp

+++ b/Source/bindings/v8/V8HiddenPropertyName.cpp

@@ -44,9 +44,8 @@ namespace WebCore {

#define V8_HIDDEN_PROPERTY_PREFIX "WebCore::HiddenProperty::"

#define V8_DEFINE_HIDDEN_PROPERTY(name) \

-v8::Handle<v8::String> V8HiddenPropertyName::name() \

+v8::Handle<v8::String> V8HiddenPropertyName::name(v8::Isolate* isolate) \

{ \

- v8::Isolate* isolate = v8::Isolate::GetCurrent(); \

V8HiddenPropertyName* hiddenPropertyName = V8PerIsolateData::from(isolate)->hiddenPropertyName(); \

if (hiddenPropertyName->m_##name.IsEmpty()) { \

createString(V8_HIDDEN_PROPERTY_PREFIX V8_AS_STRING(name), &(hiddenPropertyName->m_##name), isolate); \