Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: Source/bindings/v8/custom/V8ErrorEventCustom.cpp

Issue 23637014: Have V8HiddenPropertyName static functions take an isolate in argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 28 matching lines...) Expand all
39 #include "bindings/v8/SerializedScriptValue.h" 39 #include "bindings/v8/SerializedScriptValue.h"
40 #include "bindings/v8/V8Binding.h" 40 #include "bindings/v8/V8Binding.h"
41 #include "bindings/v8/V8DOMWrapper.h" 41 #include "bindings/v8/V8DOMWrapper.h"
42 #include "bindings/v8/V8HiddenPropertyName.h" 42 #include "bindings/v8/V8HiddenPropertyName.h"
43 #include "core/dom/ContextFeatures.h" 43 #include "core/dom/ContextFeatures.h"
44 44
45 namespace WebCore { 45 namespace WebCore {
46 46
47 void V8ErrorEvent::errorAttributeGetterCustom(v8::Local<v8::String>, const v8::P ropertyCallbackInfo<v8::Value>& info) 47 void V8ErrorEvent::errorAttributeGetterCustom(v8::Local<v8::String>, const v8::P ropertyCallbackInfo<v8::Value>& info)
48 { 48 {
49 v8::Handle<v8::Value> error = info.Holder()->GetHiddenValue(V8HiddenProperty Name::error()); 49 v8::Handle<v8::Value> error = info.Holder()->GetHiddenValue(V8HiddenProperty Name::error(info.GetIsolate()));
50 50
51 if (!error.IsEmpty()) { 51 if (!error.IsEmpty()) {
52 v8SetReturnValue(info, error); 52 v8SetReturnValue(info, error);
53 return; 53 return;
54 } 54 }
55 55
56 v8SetReturnValueNull(info); 56 v8SetReturnValueNull(info);
57 } 57 }
58 58
59 } // namespace WebCore 59 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/custom/V8CustomEventCustom.cpp ('k') | Source/bindings/v8/custom/V8HistoryCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698