Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 23637004: Mark imageblur and imagefiltersbase GM tests as ignore-failure on Android-IntelRhb-SGX544-x86 (Closed)

Created:
7 years, 3 months ago by epoger
Modified:
6 years, 6 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Mark imageblur and imagefiltersbase GM tests as ignore-failure on Android-IntelRhb-SGX544-x86 BUG=skia:1581 TBR=bsalomon Committed as https://code.google.com/p/skia/source/detail?r=11076

Patch Set 1 #

Total comments: 1

Patch Set 2 : manually_ignore_failures #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -4 lines) Patch
MM expectations/gm/Test-Android-IntelRhb-SGX544-x86-Debug/expected-results.json View 1 1 chunk +29 lines, -2 lines 1 comment Download
MM expectations/gm/Test-Android-IntelRhb-SGX544-x86-Release/expected-results.json View 1 1 chunk +29 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
epoger
https://codereview.chromium.org/23637004/diff/1/expectations/gm/Test-Android-IntelRhb-SGX544-x86-Debug/expected-results.json File expectations/gm/Test-Android-IntelRhb-SGX544-x86-Debug/expected-results.json (right): https://codereview.chromium.org/23637004/diff/1/expectations/gm/Test-Android-IntelRhb-SGX544-x86-Debug/expected-results.json#newcode13 expectations/gm/Test-Android-IntelRhb-SGX544-x86-Debug/expected-results.json:13: 5680959140053860741 Patchset 1: ran the following rebaseline command to ...
7 years, 3 months ago (2013-09-03 18:51:32 UTC) #1
epoger
Ready for review at patchset 2. https://codereview.chromium.org/23637004/diff/5001/expectations/gm/Test-Android-IntelRhb-SGX544-x86-Debug/expected-results.json File expectations/gm/Test-Android-IntelRhb-SGX544-x86-Debug/expected-results.json (right): https://codereview.chromium.org/23637004/diff/5001/expectations/gm/Test-Android-IntelRhb-SGX544-x86-Debug/expected-results.json#newcode19 expectations/gm/Test-Android-IntelRhb-SGX544-x86-Debug/expected-results.json:19: "ignore-failure": true, Patchset ...
7 years, 3 months ago (2013-09-03 18:56:20 UTC) #2
epoger
Committed as https://code.google.com/p/skia/source/detail?r=11076 , because I wanted to be here to see it land. Brian, ...
7 years, 3 months ago (2013-09-04 15:37:13 UTC) #3
bsalomon
7 years, 3 months ago (2013-09-05 13:17:15 UTC) #4
On 2013/09/04 15:37:13, epoger wrote:
> Committed as https://code.google.com/p/skia/source/detail?r=11076 , because I
> wanted to be here to see it land.
> 
> Brian, I hope you don't mind the TBR commit.

nope, thanks! Not sure how I missed this one.

Powered by Google App Engine
This is Rietveld 408576698