Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: net/socket/client_socket_pool_manager_impl.cc

Issue 2363653002: Cleanup unreachable cert adding code (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/client_socket_pool_manager_impl.cc
diff --git a/net/socket/client_socket_pool_manager_impl.cc b/net/socket/client_socket_pool_manager_impl.cc
index 69569355503986b30ec82e47c1df95ac683f522e..ade8c4fffe7c66db4d087747e6d814c166cc0903 100644
--- a/net/socket/client_socket_pool_manager_impl.cc
+++ b/net/socket/client_socket_pool_manager_impl.cc
@@ -360,22 +360,7 @@ ClientSocketPoolManagerImpl::SocketPoolInfoToValue() const {
return std::move(list);
}
-void ClientSocketPoolManagerImpl::OnCertAdded(const X509Certificate* cert) {
- FlushSocketPoolsWithError(ERR_NETWORK_CHANGED);
-}
-
-void ClientSocketPoolManagerImpl::OnCACertChanged(
- const X509Certificate* cert) {
- // We should flush the socket pools if we removed trust from a
- // cert, because a previously trusted server may have become
- // untrusted.
- //
- // We should not flush the socket pools if we added trust to a
- // cert.
- //
- // Since the OnCACertChanged method doesn't tell us what
- // kind of change it is, we have to flush the socket
- // pools to be safe.
+void ClientSocketPoolManagerImpl::OnCertDBChanged(const X509Certificate* cert) {
FlushSocketPoolsWithError(ERR_NETWORK_CHANGED);
}

Powered by Google App Engine
This is Rietveld 408576698