Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: net/socket/client_socket_factory.cc

Issue 2363653002: Cleanup unreachable cert adding code (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/client_socket_factory.cc
diff --git a/net/socket/client_socket_factory.cc b/net/socket/client_socket_factory.cc
index 42daa5a52005d110d7ae917bcbeb8b1115881cff..9d924ee742d45dc608c18df398be1dc48030dfa4 100644
--- a/net/socket/client_socket_factory.cc
+++ b/net/socket/client_socket_factory.cc
@@ -33,14 +33,8 @@ class DefaultClientSocketFactory : public ClientSocketFactory,
CertDatabase::GetInstance()->RemoveObserver(this);
}
- void OnCertAdded(const X509Certificate* cert) override {
- ClearSSLSessionCache();
- }
-
- void OnCACertChanged(const X509Certificate* cert) override {
- // Per wtc, we actually only need to flush when trust is reduced.
- // Always flush now because OnCACertChanged does not tell us this.
- // See comments in ClientSocketPoolManager::OnCACertChanged.
+ void OnCertDBChanged(const X509Certificate* cert) override {
+ // Flush sockets whenever CA trust changes.
ClearSSLSessionCache();
}

Powered by Google App Engine
This is Rietveld 408576698