Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: net/cert/nss_cert_database.h

Issue 2363653002: Cleanup unreachable cert adding code (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_CERT_NSS_CERT_DATABASE_H_ 5 #ifndef NET_CERT_NSS_CERT_DATABASE_H_
6 #define NET_CERT_NSS_CERT_DATABASE_H_ 6 #define NET_CERT_NSS_CERT_DATABASE_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 24 matching lines...) Expand all
35 35
36 // Provides functions to manipulate the NSS certificate stores. 36 // Provides functions to manipulate the NSS certificate stores.
37 // Forwards notifications about certificate changes to the global CertDatabase 37 // Forwards notifications about certificate changes to the global CertDatabase
38 // singleton. 38 // singleton.
39 class NET_EXPORT NSSCertDatabase { 39 class NET_EXPORT NSSCertDatabase {
40 public: 40 public:
41 class NET_EXPORT Observer { 41 class NET_EXPORT Observer {
42 public: 42 public:
43 virtual ~Observer() {} 43 virtual ~Observer() {}
44 44
45 // Will be called when a new certificate is added.
46 // Called with |cert| == NULL after importing a list of certificates
47 // in ImportFromPKCS12().
48 virtual void OnCertAdded(const X509Certificate* cert) {}
49
50 // Will be called when a certificate is removed.
51 virtual void OnCertRemoved(const X509Certificate* cert) {}
52
53 // Will be called when a CA certificate is changed. 45 // Will be called when a CA certificate is changed.
54 // Called with |cert| == NULL after importing a list of certificates 46 // Called with |cert| == NULL after importing a list of certificates
55 // in ImportCACerts(). 47 // in ImportCACerts().
56 virtual void OnCACertChanged(const X509Certificate* cert) {} 48 virtual void OnCertDBChanged(const X509Certificate* cert) {}
57 49
58 protected: 50 protected:
59 Observer() {} 51 Observer() {}
60 52
61 private: 53 private:
62 DISALLOW_COPY_AND_ASSIGN(Observer); 54 DISALLOW_COPY_AND_ASSIGN(Observer);
63 }; 55 };
64 56
65 // Stores per-certificate error codes for import failures. 57 // Stores per-certificate error codes for import failures.
66 struct NET_EXPORT ImportCertFailure { 58 struct NET_EXPORT ImportCertFailure {
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 static void ListCertsImpl(crypto::ScopedPK11Slot slot, 260 static void ListCertsImpl(crypto::ScopedPK11Slot slot,
269 CertificateList* certs); 261 CertificateList* certs);
270 262
271 // Gets task runner that should be used for slow tasks like certificate 263 // Gets task runner that should be used for slow tasks like certificate
272 // listing. Defaults to a base::WorkerPool runner, but may be overriden 264 // listing. Defaults to a base::WorkerPool runner, but may be overriden
273 // in tests (see SetSlowTaskRunnerForTest). 265 // in tests (see SetSlowTaskRunnerForTest).
274 scoped_refptr<base::TaskRunner> GetSlowTaskRunner() const; 266 scoped_refptr<base::TaskRunner> GetSlowTaskRunner() const;
275 267
276 protected: 268 protected:
277 // Broadcasts notifications to all registered observers. 269 // Broadcasts notifications to all registered observers.
278 void NotifyObserversOfCertAdded(const X509Certificate* cert); 270 void NotifyObserversCertDBChanged(const X509Certificate* cert);
279 void NotifyObserversOfCertRemoved(const X509Certificate* cert);
280 void NotifyObserversOfCACertChanged(const X509Certificate* cert);
281 271
282 private: 272 private:
283 // Registers |observer| to receive notifications of certificate changes. The 273 // Registers |observer| to receive notifications of certificate changes. The
284 // thread on which this is called is the thread on which |observer| will be 274 // thread on which this is called is the thread on which |observer| will be
285 // called back with notifications. 275 // called back with notifications.
286 // NOTE: Observers registered here will only receive notifications generated 276 // NOTE: Observers registered here will only receive notifications generated
287 // directly through the NSSCertDatabase, but not those from the CertDatabase. 277 // directly through the NSSCertDatabase, but not those from the CertDatabase.
288 // CertDatabase observers will receive all certificate notifications. 278 // CertDatabase observers will receive all certificate notifications.
289 void AddObserver(Observer* observer); 279 void AddObserver(Observer* observer);
290 280
(...skipping 23 matching lines...) Expand all
314 const scoped_refptr<base::ObserverListThreadSafe<Observer>> observer_list_; 304 const scoped_refptr<base::ObserverListThreadSafe<Observer>> observer_list_;
315 305
316 base::WeakPtrFactory<NSSCertDatabase> weak_factory_; 306 base::WeakPtrFactory<NSSCertDatabase> weak_factory_;
317 307
318 DISALLOW_COPY_AND_ASSIGN(NSSCertDatabase); 308 DISALLOW_COPY_AND_ASSIGN(NSSCertDatabase);
319 }; 309 };
320 310
321 } // namespace net 311 } // namespace net
322 312
323 #endif // NET_CERT_NSS_CERT_DATABASE_H_ 313 #endif // NET_CERT_NSS_CERT_DATABASE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698