[Experimental] Avoid HQ resampling of non-trivially transformed images

[Experimental] Avoid HQ resampling of non-trivially transformed images

Not for landing.

BUG=649046, 550915
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

[f(malita), 2016-09-22 21:37:30]

Description was changed from

==========
[Experimental] Avoid HQ resampling of non-trivially transformed images

Not for landing.

BUG=649046
==========

to

==========
[Experimental] Avoid HQ resampling of non-trivially transformed images

Not for landing.

BUG=649046
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[f(malita), 2016-09-22 21:37:35]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 21:38:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-09-22 21:45:14]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 21:45:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-09-22 22:45:08]

Description was changed from

==========
[Experimental] Avoid HQ resampling of non-trivially transformed images

Not for landing.

BUG=649046
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
[Experimental] Avoid HQ resampling of non-trivially transformed images

Not for landing.

BUG=649046,550915
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-09-22 23:07:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 23:07:50]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[vmpstr, 2016-09-23 18:45:38]

vmpstr@chromium.org changed reviewers:
+ vmpstr@chromium.org

[vmpstr, 2016-09-23 18:45:39]

Feel free to make this production ready. Or we can land
https://codereview.chromium.org/2361243002/

WDYT?

https://codereview.chromium.org/2363643003/diff/20001/cc/tiles/software_image...
File cc/tiles/software_image_decode_controller.cc (right):

https://codereview.chromium.org/2363643003/diff/20001/cc/tiles/software_image...
cc/tiles/software_image_decode_controller.cc:836: namespace {
Move this to the top of the file please.

https://codereview.chromium.org/2363643003/diff/20001/cc/tiles/software_image...
cc/tiles/software_image_decode_controller.cc:838: bool
shouldDrawHighQuality(const DrawImage& image,
ShouldDrawHighQuality

https://codereview.chromium.org/2363643003/diff/20001/cc/tiles/software_image...
cc/tiles/software_image_decode_controller.cc:842: if
(!image.matrix_is_decomposable()) {
braces optional for one liners

https://codereview.chromium.org/2363643003/diff/20001/cc/tiles/software_image...
cc/tiles/software_image_decode_controller.cc:856: if
(!image.matrix().isScaleTranslate()) {
Can you reorder these checks so that the easy checks are earlier than heavy
checks (that is, size check should probably be last)

https://codereview.chromium.org/2363643003/diff/20001/cc/tiles/software_image...
cc/tiles/software_image_decode_controller.cc:871: }
I wonder if we should just drop to medium for downscales. Or do you think this
would produce better results?

[f(malita), 2016-09-23 20:52:27]

On 2016/09/23 18:45:39, vmpstr wrote:
> Feel free to make this production ready. Or we can land
> https://codereview.chromium.org/2361243002/
> 
> WDYT?

Let's land yours for now, it seems safer.  We can try this more aggressive
approach on top of it later.