Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Issue 236363012: Xfermode: SSE2 implementation of softlight_modeproc (Closed)

Created:
6 years, 8 months ago by qiankun
Modified:
6 years, 8 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Xfermode: SSE2 implementation of softlight_modeproc With SSE2 optimization, performance of Xfermode_SoftLight will improve about 30% on desktop i7-3770. Here are the data: before: Xfermode_SoftLight 8888: cmsecs = 379.44 565: cmsecs = 387.74 after: Xfermode_SoftLight 8888: cmsecs = 272.29 565: cmsecs = 284.31 BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14376

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase and move SkSqrtBits_SSE2 to SkMath_opts_SSE2.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -1 line) Patch
A src/opts/SkMath_opts_SSE2.h View 1 1 chunk +43 lines, -0 lines 0 comments Download
M src/opts/SkXfermode_opts_SSE2.cpp View 1 4 chunks +84 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
qiankun
PTAL.
6 years, 8 months ago (2014-04-15 07:32:37 UTC) #1
mtklein
lgtm https://codereview.chromium.org/236363012/diff/1/src/opts/SkXfermode_opts_SSE2.cpp File src/opts/SkXfermode_opts_SSE2.cpp (right): https://codereview.chromium.org/236363012/diff/1/src/opts/SkXfermode_opts_SSE2.cpp#newcode96 src/opts/SkXfermode_opts_SSE2.cpp:96: static inline __m128i SkSqrtBits_SSE2(const __m128i& x, int count) ...
6 years, 8 months ago (2014-04-24 17:24:11 UTC) #2
qiankun
The CQ bit was checked by qiankun.miao@intel.com
6 years, 8 months ago (2014-04-25 08:10:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/qiankun.miao@intel.com/236363012/20001
6 years, 8 months ago (2014-04-25 08:10:46 UTC) #4
qiankun
https://codereview.chromium.org/236363012/diff/1/src/opts/SkXfermode_opts_SSE2.cpp File src/opts/SkXfermode_opts_SSE2.cpp (right): https://codereview.chromium.org/236363012/diff/1/src/opts/SkXfermode_opts_SSE2.cpp#newcode96 src/opts/SkXfermode_opts_SSE2.cpp:96: static inline __m128i SkSqrtBits_SSE2(const __m128i& x, int count) { ...
6 years, 8 months ago (2014-04-25 08:13:05 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 08:34:48 UTC) #6
Message was sent while issue was closed.
Change committed as 14376

Powered by Google App Engine
This is Rietveld 408576698