Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 236363005: Remove dead code from HTMLElement::parseAttribute (Closed)

Created:
6 years, 8 months ago by esprehn
Modified:
6 years, 8 months ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Remove dead code from HTMLElement::parseAttribute Element::parseAttribute does nothing so there's no reason to have a special case to call it for id, class and style attributes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171431

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M Source/core/html/HTMLElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
esprehn
6 years, 8 months ago (2014-04-14 05:28:04 UTC) #1
eseidel
lgtm
6 years, 8 months ago (2014-04-14 05:48:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/236363005/1
6 years, 8 months ago (2014-04-14 05:48:55 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 06:18:40 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 8 months ago (2014-04-14 06:18:40 UTC) #5
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 8 months ago (2014-04-14 06:46:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/236363005/1
6 years, 8 months ago (2014-04-14 06:46:23 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 07:26:52 UTC) #8
Message was sent while issue was closed.
Change committed as 171431

Powered by Google App Engine
This is Rietveld 408576698