Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: components/security_state/security_state_model.h

Issue 2363623002: Remove SecurityStateModel memoization (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_state/security_state_model.h
diff --git a/components/security_state/security_state_model.h b/components/security_state/security_state_model.h
index 5b7d4b36075373daaa13e3ce7d1fd991a1e53591..41a77ebebcca593ad2cd0c67944b3d8a5c453334 100644
--- a/components/security_state/security_state_model.h
+++ b/components/security_state/security_state_model.h
@@ -192,20 +192,12 @@ class SecurityStateModel {
SecurityStateModel();
virtual ~SecurityStateModel();
- // Returns a SecurityInfo describing the current page. Results are
- // cached so that computation is only done when the relevant security
- // state has changed.
- const SecurityInfo& GetSecurityInfo() const;
+ // Populates |result| to describe the current page.
+ void GetSecurityInfo(SecurityInfo* result) const;
void SetClient(SecurityStateModelClient* client);
private:
- // Caches the SecurityInfo for the visible page. Marked
- // mutable so that the const accessor GetSecurityInfo() can update the
- // cached values.
- mutable SecurityInfo security_info_;
- mutable VisibleSecurityState visible_security_state_;
-
SecurityStateModelClient* client_;
DISALLOW_COPY_AND_ASSIGN(SecurityStateModel);
« no previous file with comments | « chrome/browser/ui/views/location_bar/location_icon_view.cc ('k') | components/security_state/security_state_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698