chrome/browser/ssl/chrome_security_state_model_client.cc - Issue 2363623002: Remove SecurityStateModel memoization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/chrome_security_state_model_client.cc

Issue 2363623002: Remove SecurityStateModel memoization (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ssl/chrome_security_state_model_client.cc

diff --git a/chrome/browser/ssl/chrome_security_state_model_client.cc b/chrome/browser/ssl/chrome_security_state_model_client.cc

index 90acd7f2cbc2029c65c4a25f241c22d1712f72e9..59372b7612c7258a9dbf48b5252b8080e1ffb4d5 100644

--- a/chrome/browser/ssl/chrome_security_state_model_client.cc

+++ b/chrome/browser/ssl/chrome_security_state_model_client.cc

@@ -320,9 +320,9 @@ content::SecurityStyle ChromeSecurityStateModelClient::GetSecurityStyle(

return security_style;

}

-const SecurityStateModel::SecurityInfo&

-ChromeSecurityStateModelClient::GetSecurityInfo() const {

- return security_state_model_->GetSecurityInfo();

+void ChromeSecurityStateModelClient::GetSecurityInfo(

+ SecurityStateModel::SecurityInfo* result) const {

+ security_state_model_->GetSecurityInfo(result);

}

bool ChromeSecurityStateModelClient::RetrieveCert(