Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

Issue 2363623002: Remove SecurityStateModel memoization (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
index 286acd912b8b5195e211f9be5c5da109c944230a..0d7a7adf57d2be0b352277195b9e6a4d2868e14e 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
@@ -575,9 +575,11 @@ class SafeBrowsingBlockingPageBrowserTest
ChromeSecurityStateModelClient* model_client =
ChromeSecurityStateModelClient::FromWebContents(tab);
ASSERT_TRUE(model_client);
+ security_state::SecurityStateModel::SecurityInfo security_info;
+ model_client->GetSecurityInfo(&security_info);
EXPECT_EQ(security_state::SecurityStateModel::SECURITY_ERROR,
- model_client->GetSecurityInfo().security_level);
- EXPECT_TRUE(model_client->GetSecurityInfo().fails_malware_check);
+ security_info.security_level);
+ EXPECT_TRUE(security_info.fails_malware_check);
// TODO(felt): Restore this check when https://crbug.com/641187 is fixed.
// EXPECT_EQ(cert_status, model_client->GetSecurityInfo().cert_status);
}

Powered by Google App Engine
This is Rietveld 408576698