Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: ios/chrome/browser/ssl/ios_chrome_security_state_model_client.h

Issue 2363623002: Remove SecurityStateModel memoization (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_CHROME_BROWSER_SSL_IOS_CHROME_SECURITY_STATE_MODEL_CLIENT_H_ 5 #ifndef IOS_CHROME_BROWSER_SSL_IOS_CHROME_SECURITY_STATE_MODEL_CLIENT_H_
6 #define IOS_CHROME_BROWSER_SSL_IOS_CHROME_SECURITY_STATE_MODEL_CLIENT_H_ 6 #define IOS_CHROME_BROWSER_SSL_IOS_CHROME_SECURITY_STATE_MODEL_CLIENT_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "components/security_state/security_state_model.h" 11 #include "components/security_state/security_state_model.h"
12 #include "components/security_state/security_state_model_client.h" 12 #include "components/security_state/security_state_model_client.h"
13 #include "ios/web/public/web_state/web_state_user_data.h" 13 #include "ios/web/public/web_state/web_state_user_data.h"
14 14
15 namespace web { 15 namespace web {
16 class WebState; 16 class WebState;
17 } // namespace web 17 } // namespace web
18 18
19 // Uses a WebState to provide a SecurityStateModel with the 19 // Uses a WebState to provide a SecurityStateModel with the
20 // information that it needs to determine the page's security status. 20 // information that it needs to determine the page's security status.
21 class IOSChromeSecurityStateModelClient 21 class IOSChromeSecurityStateModelClient
22 : public security_state::SecurityStateModelClient, 22 : public security_state::SecurityStateModelClient,
23 public web::WebStateUserData<IOSChromeSecurityStateModelClient> { 23 public web::WebStateUserData<IOSChromeSecurityStateModelClient> {
24 public: 24 public:
25 ~IOSChromeSecurityStateModelClient() override; 25 ~IOSChromeSecurityStateModelClient() override;
26 26
27 const security_state::SecurityStateModel::SecurityInfo& GetSecurityInfo() 27 void GetSecurityInfo(
28 const; 28 security_state::SecurityStateModel::SecurityInfo* result) const;
29 29
30 // SecurityStateModelClient: 30 // SecurityStateModelClient:
31 void GetVisibleSecurityState( 31 void GetVisibleSecurityState(
32 security_state::SecurityStateModel::VisibleSecurityState* state) override; 32 security_state::SecurityStateModel::VisibleSecurityState* state) override;
33 bool RetrieveCert(scoped_refptr<net::X509Certificate>* cert) override; 33 bool RetrieveCert(scoped_refptr<net::X509Certificate>* cert) override;
34 bool UsedPolicyInstalledCertificate() override; 34 bool UsedPolicyInstalledCertificate() override;
35 bool IsOriginSecure(const GURL& url) override; 35 bool IsOriginSecure(const GURL& url) override;
36 36
37 private: 37 private:
38 explicit IOSChromeSecurityStateModelClient(web::WebState* web_state); 38 explicit IOSChromeSecurityStateModelClient(web::WebState* web_state);
39 friend class web::WebStateUserData<IOSChromeSecurityStateModelClient>; 39 friend class web::WebStateUserData<IOSChromeSecurityStateModelClient>;
40 40
41 web::WebState* web_state_; 41 web::WebState* web_state_;
42 std::unique_ptr<security_state::SecurityStateModel> security_state_model_; 42 std::unique_ptr<security_state::SecurityStateModel> security_state_model_;
43 43
44 DISALLOW_COPY_AND_ASSIGN(IOSChromeSecurityStateModelClient); 44 DISALLOW_COPY_AND_ASSIGN(IOSChromeSecurityStateModelClient);
45 }; 45 };
46 46
47 #endif // IOS_CHROME_BROWSER_SSL_IOS_CHROME_SECURITY_STATE_MODEL_CLIENT_H_ 47 #endif // IOS_CHROME_BROWSER_SSL_IOS_CHROME_SECURITY_STATE_MODEL_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698