Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: chrome/renderer/extensions/v8_schema_registry.cc

Issue 23636015: Remove unsafe access hacks from ScopedPersistent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/v8_schema_registry.cc
diff --git a/chrome/renderer/extensions/v8_schema_registry.cc b/chrome/renderer/extensions/v8_schema_registry.cc
index 33d10d95a9943c888413cb4a2a18683cc24b6ba0..f5c2c7146cb611930bc1e767db6b2b2562d39272 100644
--- a/chrome/renderer/extensions/v8_schema_registry.cc
+++ b/chrome/renderer/extensions/v8_schema_registry.cc
@@ -108,12 +108,12 @@ v8::Handle<v8::Context> V8SchemaRegistry::GetOrCreateContext(
v8::Isolate* isolate) {
// It's ok to create local handles in this function, since this is only called
// when we have a HandleScope.
- if (context_.get().IsEmpty()) {
+ if (context_.IsEmpty()) {
v8::Handle<v8::Context> context = v8::Context::New(isolate);
context_.reset(context);
return context;
}
- return v8::Local<v8::Context>::New(isolate, context_.get());
+ return context_.NewHandle(isolate);
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698