Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: chrome/renderer/extensions/object_backed_native_handler.cc

Issue 23636015: Remove unsafe access hacks from ScopedPersistent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/object_backed_native_handler.cc
diff --git a/chrome/renderer/extensions/object_backed_native_handler.cc b/chrome/renderer/extensions/object_backed_native_handler.cc
index 9c24dc900e1763a02229b46ba76d2b891f0dc942..a58f752d666286b461f6ab7e2afd6ccbc8fbebdd 100644
--- a/chrome/renderer/extensions/object_backed_native_handler.cc
+++ b/chrome/renderer/extensions/object_backed_native_handler.cc
@@ -32,7 +32,7 @@ ObjectBackedNativeHandler::~ObjectBackedNativeHandler() {
}
v8::Handle<v8::Object> ObjectBackedNativeHandler::NewInstance() {
- return object_template_->NewInstance();
+ return object_template_.NewHandle(v8::Isolate::GetCurrent())->NewInstance();
}
// static
@@ -68,7 +68,7 @@ void ObjectBackedNativeHandler::RouteFunction(
v8::External::New(new HandlerFunction(handler_function)));
v8::Handle<v8::FunctionTemplate> function_template =
v8::FunctionTemplate::New(Router, local_data);
- object_template_->Set(name.c_str(), function_template);
+ object_template_.NewHandle(isolate)->Set(name.c_str(), function_template);
router_data_.push_back(UnsafePersistent<v8::Object>(&data));
}

Powered by Google App Engine
This is Rietveld 408576698