Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1120)

Issue 23636014: [Files.app] Use generateTopLevelEntries() method to retrieve the list on the top level (Closed)

Created:
7 years, 3 months ago by yoshiki
Modified:
7 years, 3 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

[Files.app] Use generateTopLevelEntries() method to retrieve the list on the top level This patch fixes the bug that the directory list is not drawn correctly sometimes. Previously, DirectoryTree.updateSubDirectories() tries to retrieve an entries from the file system. But the directory structure of the top level is different from the file system, instead, we need to use the special list. This patch change the updateSubDirectories() to use the special list. BUG=286421 TEST=manual R=hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222211

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M chrome/browser/resources/file_manager/js/directory_tree.js View 1 1 chunk +4 lines, -10 lines 2 comments Download

Messages

Total messages: 9 (0 generated)
yoshiki
@hirono: could you take a look? Thanks.
7 years, 3 months ago (2013-09-09 10:42:37 UTC) #1
hirono
https://codereview.chromium.org/23636014/diff/2001/chrome/browser/resources/file_manager/js/directory_tree.js File chrome/browser/resources/file_manager/js/directory_tree.js (right): https://codereview.chromium.org/23636014/diff/2001/chrome/browser/resources/file_manager/js/directory_tree.js#newcode598 chrome/browser/resources/file_manager/js/directory_tree.js:598: recursive, opt_successCallback, opt_errorCallback) { opt_errorCallback will not be called. ...
7 years, 3 months ago (2013-09-10 00:51:13 UTC) #2
yoshiki
https://codereview.chromium.org/23636014/diff/2001/chrome/browser/resources/file_manager/js/directory_tree.js File chrome/browser/resources/file_manager/js/directory_tree.js (right): https://codereview.chromium.org/23636014/diff/2001/chrome/browser/resources/file_manager/js/directory_tree.js#newcode598 chrome/browser/resources/file_manager/js/directory_tree.js:598: recursive, opt_successCallback, opt_errorCallback) { On 2013/09/10 00:51:13, hirono wrote: ...
7 years, 3 months ago (2013-09-10 01:01:00 UTC) #3
hirono
Thanks, lgtm!
7 years, 3 months ago (2013-09-10 01:09:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/23636014/2001
7 years, 3 months ago (2013-09-10 01:48:48 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-10 02:20:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/23636014/2001
7 years, 3 months ago (2013-09-10 02:30:45 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-10 02:39:38 UTC) #8
yoshiki
7 years, 3 months ago (2013-09-10 08:32:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r222211 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698