chrome/browser/notifications/message_center_notifications_unittest_win.cc - Issue 23636010: Notifications: Add cross-platform UMA: ShowMessageCenter, ShowSettings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/message_center_notifications_unittest_win.cc

Issue 23636010: Notifications: Add cross-platform UMA: ShowMessageCenter, ShowSettings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added the hash to chromeactions.txt Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/message_center_notifications_browsertest.cc ('k') | chrome/browser/ui/views/message_center/web_notification_tray.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/message_center_notifications_unittest_win.cc

diff --git a/chrome/browser/notifications/message_center_notifications_unittest_win.cc b/chrome/browser/notifications/message_center_notifications_unittest_win.cc

index 01c8534012b2391e7e620e0e018832a3b4eba069..bd945609fde1e80e25cb3e889c4dffaf4e3729e4 100644

--- a/chrome/browser/notifications/message_center_notifications_unittest_win.cc

+++ b/chrome/browser/notifications/message_center_notifications_unittest_win.cc

@@ -21,6 +21,7 @@

#include "ui/message_center/message_center_impl.h"

#include "ui/message_center/message_center_tray.h"

#include "ui/message_center/message_center_tray_delegate.h"

+#include "ui/message_center/message_center_types.h"

#include "ui/message_center/notifier_settings.h"

namespace message_center {

@@ -158,7 +159,7 @@ TEST_F(MessageCenterNotificationManagerTest,

FirstRunNotShownWithMessageCenter) {

TestingProfile profile;

notification_manager()->Add(GetANotification("test"), &profile);

- message_center()->SetMessageCenterVisible(true);

+ message_center()->SetVisibility(message_center::VISIBILITY_MESSAGE_CENTER);

run_loop()->RunUntilIdle();

EXPECT_FALSE(notification_manager()->FirstRunTimerIsActive());

EXPECT_FALSE(DidFirstRunPref());