chrome/browser/notifications/message_center_notifications_browsertest.cc - Issue 23636010: Notifications: Add cross-platform UMA: ShowMessageCenter, ShowSettings.

Unified Diff: chrome/browser/notifications/message_center_notifications_browsertest.cc

Issue 23636010: Notifications: Add cross-platform UMA: ShowMessageCenter, ShowSettings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove spurious test code. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/message_center_notification_manager.cc ('k') | chrome/browser/notifications/message_center_notifications_unittest_win.cc » ('j') | chrome/browser/ui/views/message_center/web_notification_tray.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/message_center_notifications_browsertest.cc

diff --git a/chrome/browser/notifications/message_center_notifications_browsertest.cc b/chrome/browser/notifications/message_center_notifications_browsertest.cc

index 84cde473fc6c8155b202e0c4229992adfa9e59c1..8d13aaf20b8bf2758469a1d8ff8af4d979e102c1 100644

--- a/chrome/browser/notifications/message_center_notifications_browsertest.cc

+++ b/chrome/browser/notifications/message_center_notifications_browsertest.cc

@@ -283,12 +283,12 @@ IN_PROC_BROWSER_TEST_F(MessageCenterNotificationsTest,

TestDelegate* delegate2;

manager()->Add(CreateTestNotification("n", &delegate), profile());

- message_center()->SetMessageCenterVisible(true);

+ message_center()->SetVisibility(message_center::VISIBILITY_MESSAGE_CENTER);

manager()->Add(CreateTestNotification("n2", &delegate2), profile());

EXPECT_EQ("add-n", observer.log());

- message_center()->SetMessageCenterVisible(false);

+ message_center()->SetVisibility(message_center::VISIBILITY_TRANSIENT);

EXPECT_EQ("add-n_add-n2", observer.log());

@@ -323,7 +323,7 @@ IN_PROC_BROWSER_TEST_F(MessageCenterNotificationsTest,

Notification notification = CreateTestNotification("n", &delegate);

manager()->Add(notification, profile());

message_center()->ClickOnNotification("n");

- message_center()->SetMessageCenterVisible(true);

+ message_center()->SetVisibility(message_center::VISIBILITY_MESSAGE_CENTER);

observer.reset_log();

notification.set_title(ASCIIToUTF16("title2"));

manager()->Update(notification, profile());

@@ -362,7 +362,7 @@ IN_PROC_BROWSER_TEST_F(

Notification notification = CreateTestNotification("n", &delegate);

manager()->Add(notification, profile());

message_center()->ClickOnNotification("n");

- message_center()->SetMessageCenterVisible(true);

+ message_center()->SetVisibility(message_center::VISIBILITY_MESSAGE_CENTER);

observer.reset_log();

notification.set_type(message_center::NOTIFICATION_TYPE_PROGRESS);

manager()->Update(notification, profile());

@@ -401,7 +401,7 @@ IN_PROC_BROWSER_TEST_F(MessageCenterNotificationsTest,

notification.set_type(message_center::NOTIFICATION_TYPE_PROGRESS);

manager()->Add(notification, profile());

message_center()->ClickOnNotification("n");

- message_center()->SetMessageCenterVisible(true);

+ message_center()->SetVisibility(message_center::VISIBILITY_MESSAGE_CENTER);

observer.reset_log();

notification.set_progress(50);

manager()->Update(notification, profile());