Notifications: Add cross-platform UMA: ShowMessageCenter, ShowSettings.

ui/message_center/message_center.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_MESSAGE_CENTER_MESSAGE_CENTER_H_
 #define UI_MESSAGE_CENTER_MESSAGE_CENTER_H_
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/observer_list.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/message_center/message_center_export.h"
 #include "ui/message_center/notification_list.h"
 #include "ui/message_center/notification_types.h"
 
 class TrayViewControllerTest;
 
 namespace base {
 class DictionaryValue;
 }
 
 // Interface to manage the NotificationList. The client (e.g. Chrome) calls
 // [Add|Remove|Update]Notification to create and update notifications in the
 // list. It also sends those changes to its observers when a notification
 // is shown, closed, or clicked on.
-// It can also implement Delegate to ask platform-dependent features like
-// disabling extensions or opening settings.
 
 namespace message_center {
 
 class MessageCenterObserver;
 class NotificationList;
 class NotifierSettingsDelegate;
 class NotifierSettingsProvider;
 
+enum Visibility {

[Jun Mukai, 2013/09/09 17:12:35]

It would be better to declare this enum in another file, so its user just
include that simple file.
It would be message_center_style.h, or _util.h, or add new _types.h file (ash
uses _style.h file, like ash/shelf/shelf_types.h)

[dewittj, 2013/09/10 21:23:24]

Done.

+  // When nothing or just toast popups are being displayed.
+  VISIBILITY_TRANSIENT = 0,
+  // When the message center view is being displayed.
+  VISIBILITY_MESSAGE_CENTER,
+  // When the settings view is being displayed.
+  VISIBILITY_SETTINGS
+};
+
 class MESSAGE_CENTER_EXPORT MessageCenter {
  public:
   // Creates the global message center object.
   static void Initialize();
 
   // Returns the global message center object. Initialize must be called first.
   static MessageCenter* Get();
 
   // Destroys the global message_center object.
   static void Shutdown();
 
-  class MESSAGE_CENTER_EXPORT Delegate {
-   public:
-    virtual ~Delegate();
-
-    // Request to show the notification settings (|notification_id| is used
-    // to identify the requesting browser context).
-    virtual void ShowSettings(const std::string& notification_id) = 0;
-  };
-
-  // Called to set the delegate.  Generally called only once, except in tests.
-  // Changing the delegate does not affect notifications in its
-  // NotificationList.
-  virtual void SetDelegate(Delegate* delegate) = 0;
-
   // Management of the observer list.
   virtual void AddObserver(MessageCenterObserver* observer) = 0;
   virtual void RemoveObserver(MessageCenterObserver* observer) = 0;
 
   // Queries of current notification list status.
   virtual size_t NotificationCount() const = 0;
   virtual size_t UnreadNotificationCount() const = 0;
   virtual bool HasPopupNotifications() const = 0;
   virtual bool HasNotification(const std::string& id) = 0;
   virtual bool IsQuietMode() const = 0;
@@ skipping 32 matching lines @@
                                          int button_index,
                                          const gfx::Image& image) = 0;
 
   // Operations happening especially from GUIs: click, expand, disable,
   // and settings.
   // Searches through the notifications and disables any that match the
   // extension id given.
   virtual void DisableNotificationsByNotifier(
       const NotifierId& notifier_id) = 0;
 
-  // TODO(mukai): settings can be in another class?
-  // Shows the settings for a web notification (profile is identified by the
-  // given notification id).
-  virtual void ShowNotificationSettings(const std::string& id) = 0;
-
   // Reformat a notification to show its entire text content.
   virtual void ExpandNotification(const std::string& id) = 0;
 
   // This should be called by UI classes when a notification is clicked to
   // trigger the notification's delegate callback and also update the message
   // center observers.
   virtual void ClickOnNotification(const std::string& id) = 0;
 
   // This should be called by UI classes when a notification button is clicked
   // to trigger the notification's delegate callback and also update the message
@@ skipping 21 matching lines @@
   virtual NotifierSettingsProvider* GetNotifierSettingsProvider() = 0;
 
   // This can be called to change the quiet mode state (without a timeout).
   virtual void SetQuietMode(bool in_quiet_mode) = 0;
 
   // Temporarily enables quiet mode for |expires_in| time.
   virtual void EnterQuietModeWithExpire(const base::TimeDelta& expires_in) = 0;
 
   // Informs the notification list whether the message center is visible.
   // This affects whether or not a message has been "read".
-  virtual void SetMessageCenterVisible(bool visible) = 0;
+  virtual void SetVisibility(Visibility visible) = 0;
 
   // Allows querying the visibility of the center.
   virtual bool IsMessageCenterVisible() = 0;
 
   // UI classes should call this when there is cause to leave popups visible for
   // longer than the default (for example, when the mouse hovers over a popup).
   virtual void PausePopupTimers() = 0;
 
   // UI classes should call this when the popup timers should restart (for
   // example, after the mouse leaves the popup.)
   virtual void RestartPopupTimers() = 0;
 
  protected:
   friend class ::TrayViewControllerTest;
   virtual void DisableTimersForTest() = 0;
 
   MessageCenter();
   virtual ~MessageCenter();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(MessageCenter);
 };
 
 }  // namespace message_center
 
 #endif  // UI_MESSAGE_CENTER_MESSAGE_CENTER_H_