Issue 23636006: Introduce toSVGViewElement(), and refactor setupInitialView() using it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23636006: Introduce toSVGViewElement(), and refactor setupInitialView() using it (Closed)

Created:
7 years, 3 months ago by gyuyoung-inactive

Modified:
7 years, 3 months ago

Reviewers:
tkent

CC:
blink-reviews, pdr, eae+blinkwatch, Stephen Chennney, f(malita), dglazkov+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Introduce toSVGViewElement(), and refactor setupInitialView() using it As a step to clean-up static_cast<SVGXXX>, toSVGTextElement() is added to clean-up static_cast<SVGTextElement*>. Besides this cl does refactoring duplicated condition checking in setupInitialView(). BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157206

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -10 lines)			Patch
	M	Source/core/svg/SVGSVGElement.cpp	View		1 chunk	+11 lines, -10 lines	0 comments	Download
	M	Source/core/svg/SVGViewElement.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23636006/1

7 years, 3 months ago (2013-09-04 06:04:46 UTC) #3

Message was sent while issue was closed.

Change committed as 157206

Expand Messages | Collapse Messages