Fixed how Apps Developer Tools is enabled/disabled

chrome/browser/extensions/install_tracker.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/install_tracker.h"
 
 #include "base/bind.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/extension_prefs.h"
 #include "chrome/common/pref_names.h"
@@ skipping 83 matching lines @@
       FOR_EACH_OBSERVER(InstallObserver, observers_,
                         OnExtensionLoaded(extension));
       break;
     }
     case chrome::NOTIFICATION_EXTENSION_UNLOADED: {
       const content::Details<extensions::UnloadedExtensionInfo>& unload_info(
           details);
       const Extension* extension = unload_info->extension;
       FOR_EACH_OBSERVER(InstallObserver, observers_,
                         OnExtensionUnloaded(extension));
-      if (unload_info->reason == extension_misc::UNLOAD_REASON_UNINSTALL)
-        FOR_EACH_OBSERVER(InstallObserver, observers_,
-                          OnExtensionUninstalled(extension));

[asargent_no_longer_on_chrome, 2013/08/30 22:23:00]

I think removing this code block is definitely correct - we should not be
generating additional uninstall events here; instead that should come from the
case in this switch statement matching NOTIFICATION_EXTENSION_UNINSTALLED. 

(ie at a higher level, when something's getting uninstalled they should first
fire a NOTIFICATION_EXTENSION_UNLOADED notification followed by a
NOTIFICATION_EXTENSION_UNINSTALLED one)

       break;
     }
     case chrome::NOTIFICATION_EXTENSION_UNINSTALLED: {
       const Extension* extension =
           content::Details<const Extension>(details).ptr();
 
       FOR_EACH_OBSERVER(InstallObserver, observers_,
                         OnExtensionUninstalled(extension));
       break;
     }
@@ skipping 11 matching lines @@
     default:
       NOTREACHED();
   }
 }
 
 void InstallTracker::OnAppsReordered() {
   FOR_EACH_OBSERVER(InstallObserver, observers_, OnAppsReordered());
 }
 
 }  // namespace extensions