[turbofan] Add proper type guards to escape analysis.

[turbofan] Add proper type guards to escape analysis.

This makes sure the {EscapeAnalysisReducer} inserts proper {TypeGuard}
nodes if the replacement node is not a subtype of the original node.
This happens predominantly for code that has been made unreachable by
type checks.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-640497
BUG=chromium:640497
Committed: https://crrev.com/4b2c6d03e444e91cc4f02539abc0633406dc66d3
Cr-Commit-Position: refs/heads/master@{#39656}

[Michael Starzinger, 2016-09-22 14:47:46]

Description was changed from

==========
[turbofan] Add proper type guards to escape analysis.

This makes sure the {EscapeAnalysisReducer} inserts proper {TypeGuard}
nodes in case the orignial type has been more precise than the type of
the replacement. This happens predominantly for code that has been made
unreachable by type checks.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-640497
BUG=chromium:640497
==========

to

==========
[turbofan] Add proper type guards to escape analysis.

This makes sure the {EscapeAnalysisReducer} inserts proper {TypeGuard}
nodes in case the original type has been more precise than the type of
the replacement. This happens predominantly for code that has been made
unreachable by type checks.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-640497
BUG=chromium:640497
==========

[Michael Starzinger, 2016-09-22 14:47:55]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 14:48:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2016-09-22 15:18:58]

On 2016/09/22 14:50:47, Michael Starzinger wrote:

LGTM, but let me double check with Benedikt that check-elimination does not
interfere with this somehow.

One clarification - I think that the original type does not have to be more
precise, it could be completely different (even disjoint).

[commit-bot: I haz the power, 2016-09-22 15:23:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 15:23:25]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-09-22 15:32:01]

Description was changed from

==========
[turbofan] Add proper type guards to escape analysis.

This makes sure the {EscapeAnalysisReducer} inserts proper {TypeGuard}
nodes in case the original type has been more precise than the type of
the replacement. This happens predominantly for code that has been made
unreachable by type checks.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-640497
BUG=chromium:640497
==========

to

==========
[turbofan] Add proper type guards to escape analysis.

This makes sure the {EscapeAnalysisReducer} inserts proper {TypeGuard}
nodes in case the replacement type is not a subtype of original type.
This happens predominantly for code that has been made unreachable by
type checks.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-640497
BUG=chromium:640497
==========

[Michael Starzinger, 2016-09-22 15:33:33]

On 2016/09/22 15:18:58, Jarin wrote:
> On 2016/09/22 14:50:47, Michael Starzinger wrote:
> 
> LGTM, but let me double check with Benedikt that check-elimination does not
> interfere with this somehow.
> 
> One clarification - I think that the original type does not have to be more
> precise, it could be completely different (even disjoint).

Yes, the phrasing with "preciseness" also confused me when I looked at the load
elimination code. I rephrased the comment.

[Michael Starzinger, 2016-09-22 15:33:48]

Description was changed from

==========
[turbofan] Add proper type guards to escape analysis.

This makes sure the {EscapeAnalysisReducer} inserts proper {TypeGuard}
nodes in case the replacement type is not a subtype of original type.
This happens predominantly for code that has been made unreachable by
type checks.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-640497
BUG=chromium:640497
==========

to

==========
[turbofan] Add proper type guards to escape analysis.

This makes sure the {EscapeAnalysisReducer} inserts proper {TypeGuard}
nodes in case the replacement node is not a subtype of original node.
This happens predominantly for code that has been made unreachable by
type checks.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-640497
BUG=chromium:640497
==========

[Michael Starzinger, 2016-09-22 15:36:53]

Description was changed from

==========
[turbofan] Add proper type guards to escape analysis.

This makes sure the {EscapeAnalysisReducer} inserts proper {TypeGuard}
nodes in case the replacement node is not a subtype of original node.
This happens predominantly for code that has been made unreachable by
type checks.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-640497
BUG=chromium:640497
==========

to

==========
[turbofan] Add proper type guards to escape analysis.

This makes sure the {EscapeAnalysisReducer} inserts proper {TypeGuard}
nodes if the replacement node is not a subtype of the original node.
This happens predominantly for code that has been made unreachable by
type checks.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-640497
BUG=chromium:640497
==========

[Michael Starzinger, 2016-09-23 08:43:46]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-09-23 08:43:47]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2363573003/#ps20001
(title: "Better comment.")

[commit-bot: I haz the power, 2016-09-23 08:43:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 10:44:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 10:44:33]

Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build
URL)
  v8_win_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)

[commit-bot: I haz the power, 2016-09-23 11:02:21]

Description was changed from

==========
[turbofan] Add proper type guards to escape analysis.

This makes sure the {EscapeAnalysisReducer} inserts proper {TypeGuard}
nodes if the replacement node is not a subtype of the original node.
This happens predominantly for code that has been made unreachable by
type checks.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-640497
BUG=chromium:640497
==========

to

==========
[turbofan] Add proper type guards to escape analysis.

This makes sure the {EscapeAnalysisReducer} inserts proper {TypeGuard}
nodes if the replacement node is not a subtype of the original node.
This happens predominantly for code that has been made unreachable by
type checks.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-640497
BUG=chromium:640497

Committed: https://crrev.com/4b2c6d03e444e91cc4f02539abc0633406dc66d3
Cr-Commit-Position: refs/heads/master@{#39656}
==========

[Michael Starzinger, 2016-09-23 11:02:22]

Description was changed from

==========
[turbofan] Add proper type guards to escape analysis.

This makes sure the {EscapeAnalysisReducer} inserts proper {TypeGuard}
nodes if the replacement node is not a subtype of the original node.
This happens predominantly for code that has been made unreachable by
type checks.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-640497
BUG=chromium:640497

Committed: https://crrev.com/4b2c6d03e444e91cc4f02539abc0633406dc66d3
Cr-Commit-Position: refs/heads/master@{#39656}
==========

to

==========
[turbofan] Add proper type guards to escape analysis.

This makes sure the {EscapeAnalysisReducer} inserts proper {TypeGuard}
nodes if the replacement node is not a subtype of the original node.
This happens predominantly for code that has been made unreachable by
type checks.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-640497
BUG=chromium:640497

Committed:
https://chromium.googlesource.com/v8/v8/+/4b2c6d03e444e91cc4f02539abc0633406d...
==========

[commit-bot: I haz the power, 2016-09-23 11:02:22]

Patchset 2 (id:??) landed as
https://crrev.com/4b2c6d03e444e91cc4f02539abc0633406dc66d3
Cr-Commit-Position: refs/heads/master@{#39656}

[Michael Starzinger, 2016-09-23 11:02:23]

Committed patchset #2 (id:20001) manually as
4b2c6d03e444e91cc4f02539abc0633406dc66d3 (presubmit successful).