third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py - Issue 2363573002: Move ViewHostMsg_CreateWindow to mojom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py

Issue 2363573002: Move ViewHostMsg_CreateWindow to mojom (Closed)

Patch Set: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py b/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py

index 2efad3274b4ef7b6445b715fce2487f7150b1ab2..31dc24cf1ce9527835e49c14ae035e3046832858 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py

@@ -3502,6 +3502,7 @@ def check_identifier_name_in_declaration(filename, line_number, line, file_state

# Various exceptions to the rule: JavaScript op codes functions, const_iterator.

if (not (filename.find('JavaScriptCore') >= 0 and modified_identifier.find('op_') >= 0)

and not (filename.find('gtk') >= 0 and modified_identifier.startswith('webkit_') >= 0)

+ and not (filename.find('StructTraits.h') >= 0)

and not modified_identifier.startswith('tst_')

and not modified_identifier.startswith('webkit_dom_object_')

and not modified_identifier.startswith('webkit_soup')

« no previous file with comments | « third_party/WebKit/PRESUBMIT.py ('k') | third_party/WebKit/public/BUILD.gn » ('j') | no next file with comments »