Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2363573002: Move ViewHostMsg_CreateWindow to mojom (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/common/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_impl.h" 5 #include "content/browser/web_contents/web_contents_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <cmath> 9 #include <cmath>
10 #include <utility> 10 #include <utility>
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 #include "content/browser/web_contents/web_contents_view_guest.h" 76 #include "content/browser/web_contents/web_contents_view_guest.h"
77 #include "content/browser/webui/generic_handler.h" 77 #include "content/browser/webui/generic_handler.h"
78 #include "content/browser/webui/web_ui_controller_factory_registry.h" 78 #include "content/browser/webui/web_ui_controller_factory_registry.h"
79 #include "content/browser/webui/web_ui_impl.h" 79 #include "content/browser/webui/web_ui_impl.h"
80 #include "content/common/browser_plugin/browser_plugin_constants.h" 80 #include "content/common/browser_plugin/browser_plugin_constants.h"
81 #include "content/common/browser_plugin/browser_plugin_messages.h" 81 #include "content/common/browser_plugin/browser_plugin_messages.h"
82 #include "content/common/frame_messages.h" 82 #include "content/common/frame_messages.h"
83 #include "content/common/input_messages.h" 83 #include "content/common/input_messages.h"
84 #include "content/common/page_messages.h" 84 #include "content/common/page_messages.h"
85 #include "content/common/page_state_serialization.h" 85 #include "content/common/page_state_serialization.h"
86 #include "content/common/render_message_filter.mojom.h"
86 #include "content/common/site_isolation_policy.h" 87 #include "content/common/site_isolation_policy.h"
87 #include "content/common/view_messages.h" 88 #include "content/common/view_messages.h"
88 #include "content/public/browser/ax_event_notification_details.h" 89 #include "content/public/browser/ax_event_notification_details.h"
89 #include "content/public/browser/browser_context.h" 90 #include "content/public/browser/browser_context.h"
90 #include "content/public/browser/browser_plugin_guest_manager.h" 91 #include "content/public/browser/browser_plugin_guest_manager.h"
91 #include "content/public/browser/content_browser_client.h" 92 #include "content/public/browser/content_browser_client.h"
92 #include "content/public/browser/devtools_agent_host.h" 93 #include "content/public/browser/devtools_agent_host.h"
93 #include "content/public/browser/download_manager.h" 94 #include "content/public/browser/download_manager.h"
94 #include "content/public/browser/download_url_parameters.h" 95 #include "content/public/browser/download_url_parameters.h"
95 #include "content/public/browser/guest_mode.h" 96 #include "content/public/browser/guest_mode.h"
(...skipping 1898 matching lines...) Expand 10 before | Expand all | Expand 10 after
1994 WasShown(); 1995 WasShown();
1995 else if (!visible) 1996 else if (!visible)
1996 WasHidden(); 1997 WasHidden();
1997 } 1998 }
1998 1999
1999 void WebContentsImpl::CreateNewWindow( 2000 void WebContentsImpl::CreateNewWindow(
2000 SiteInstance* source_site_instance, 2001 SiteInstance* source_site_instance,
2001 int32_t route_id, 2002 int32_t route_id,
2002 int32_t main_frame_route_id, 2003 int32_t main_frame_route_id,
2003 int32_t main_frame_widget_route_id, 2004 int32_t main_frame_widget_route_id,
2004 const ViewHostMsg_CreateWindow_Params& params, 2005 const mojom::CreateNewWindowParams& params,
2005 SessionStorageNamespace* session_storage_namespace) { 2006 SessionStorageNamespace* session_storage_namespace) {
2006 // We usually create the new window in the same BrowsingInstance (group of 2007 // We usually create the new window in the same BrowsingInstance (group of
2007 // script-related windows), by passing in the current SiteInstance. However, 2008 // script-related windows), by passing in the current SiteInstance. However,
2008 // if the opener is being suppressed (in a non-guest), we create a new 2009 // if the opener is being suppressed (in a non-guest), we create a new
2009 // SiteInstance in its own BrowsingInstance. 2010 // SiteInstance in its own BrowsingInstance.
2010 bool is_guest = BrowserPluginGuest::IsGuest(this); 2011 bool is_guest = BrowserPluginGuest::IsGuest(this);
2011 2012
2012 // If the opener is to be suppressed, the new window can be in any process. 2013 // If the opener is to be suppressed, the new window can be in any process.
2013 // Since routing ids are process specific, we must not have one passed in 2014 // Since routing ids are process specific, we must not have one passed in
2014 // as argument here. 2015 // as argument here.
(...skipping 3238 matching lines...) Expand 10 before | Expand all | Expand 10 after
5253 dialog_manager_ = dialog_manager; 5254 dialog_manager_ = dialog_manager;
5254 } 5255 }
5255 5256
5256 void WebContentsImpl::RemoveBindingSet(const std::string& interface_name) { 5257 void WebContentsImpl::RemoveBindingSet(const std::string& interface_name) {
5257 auto it = binding_sets_.find(interface_name); 5258 auto it = binding_sets_.find(interface_name);
5258 if (it != binding_sets_.end()) 5259 if (it != binding_sets_.end())
5259 binding_sets_.erase(it); 5260 binding_sets_.erase(it);
5260 } 5261 }
5261 5262
5262 } // namespace content 5263 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/common/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698