Move ViewHostMsg_CreateWindow to mojom

content/common/render_message_filter.mojom

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 module content.mojom;
 
+import "content/public/common/window_container_type.mojom";
+import "third_party/WebKit/public/platform/referrer.mojom";
+import "third_party/WebKit/public/web/window_features.mojom";
+import "ui/base/mojo/window_open_disposition.mojom";
+import "url/mojo/url.mojom";
+
+struct CreateNewWindowParams {
+  // Routing ID of the view initiating the open.
+  int32 opener_id;
+
+  // True if this open request came in the context of a user gesture.
+  bool user_gesture;
+
+  // Type of window requested.
+  WindowContainerType window_container_type;
+
+  // The session storage namespace ID this view should use.
+  int64 session_storage_namespace_id;
+
+  // The name of the resulting frame that should be created (empty if none
+  // has been specified). UTF8 encoded string.
+  string frame_name;
+
+  // The routing id of the frame initiating the open.
+  int32 opener_render_frame_id;
+
+  // The URL of the frame initiating the open.
+  url.mojom.Url opener_url;
+
+  // The URL of the top frame containing the opener.
+  url.mojom.Url opener_top_level_frame_url;
+
+  // The security origin of the frame initiating the open.
+  url.mojom.Url opener_security_origin;
+
+  // Whether the opener will be suppressed in the new window, in which case
+  // scripting the new window is not allowed.
+  bool opener_suppressed;
+
+  // Whether the window should be opened in the foreground, background, etc.
+  ui.mojom.WindowOpenDisposition disposition;
+
+  // The URL that will be loaded in the new window (empty if none has been
+  // sepcified).
+  url.mojom.Url target_url;
+
+  // The referrer that will be used to load |target_url| (empty if none has
+  // been specified).
+  blink.mojom.Referrer referrer;
+
+  // The window features to use for the new view.
+  blink.mojom.WindowFeatures features;

[ncarter (slow), 2016/09/27 20:32:41]

I double checked, and removing |additional_features| seems okay.

[Ken Rockot(use gerrit already), 2016/09/27 21:05:41]

Ack.

+};
+
+struct CreateNewWindowReply {
+  // The ID of the view to be created. If the ID is MSG_ROUTING_NONE, then the
+  // view couldn't be created.
+  int32 route_id;
+
+  // The ID of the main frame hosted in the view.
+  int32 main_frame_route_id;

[ncarter (slow), 2016/09/27 20:32:41]

Long-term, do you think we'll eventually be returning FrameHost mojom interfaces
here (and other places where we mint routing ids)?

[Ken Rockot(use gerrit already), 2016/09/27 21:05:41]

Yes, that's the idea. I may even try to start pairing primordial interfaces with
routing IDs sooner rather than later if it means we can avoid routing ID params
in other message conversions (i.e. imagine if every message which introduced a
new routing ID to its receiver also provided an AssociatedInterfaceProviderPtr).

Starting small though, I decided to stick with rote conversion here.

[ncarter (slow), 2016/09/27 22:47:52]

Looking forward to seeing that happen.

I still have on my TODO list to port CreateNewWindow from View to Frame (needed
to fix bug 627852). CreateWindow logically belongs on frame, because window
creation is an operation on the opener. Your CL here should make that process a
lot easier; when I get back to that bug, I'll be sure to check in with you, to
avoid conflicts.

+
+  // The ID of the widget for the main frame.
+  int32 main_frame_widget_route_id;
+
+  // Duplicated from CreateNewWindowParams because legacy code.
+  int64 cloned_session_storage_namespace_id;
+};
+
 interface RenderMessageFilter {
   // Synchronously generates a new routing ID for the caller.
   [Sync] GenerateRoutingID() => (int32 routing_id);
+
+  // Sent by the renderer when it is creating a new window.  The browser creates
+  // a tab for it.  If |reply.route_id| is MSG_ROUTING_NONE, the view couldn't
+  // be created.
+  [Sync] CreateNewWindow(CreateNewWindowParams params)
+      => (CreateNewWindowReply reply);
 };