Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: content/browser/renderer_host/render_view_host_delegate.h

Issue 2363573002: Move ViewHostMsg_CreateWindow to mojom (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <string> 10 #include <string>
11 11
12 #include "base/callback.h" 12 #include "base/callback.h"
13 #include "base/process/kill.h" 13 #include "base/process/kill.h"
14 #include "base/strings/string16.h" 14 #include "base/strings/string16.h"
15 #include "content/browser/dom_storage/session_storage_namespace_impl.h" 15 #include "content/browser/dom_storage/session_storage_namespace_impl.h"
16 #include "content/common/content_export.h" 16 #include "content/common/content_export.h"
17 #include "net/base/load_states.h" 17 #include "net/base/load_states.h"
18 #include "third_party/WebKit/public/web/WebPopupType.h" 18 #include "third_party/WebKit/public/web/WebPopupType.h"
19 #include "ui/base/window_open_disposition.h" 19 #include "ui/base/window_open_disposition.h"
20 20
21 class GURL; 21 class GURL;
22 class SkBitmap; 22 class SkBitmap;
23 struct ViewHostMsg_CreateWindow_Params;
24 struct FrameHostMsg_DidCommitProvisionalLoad_Params; 23 struct FrameHostMsg_DidCommitProvisionalLoad_Params;
25 24
26 namespace base { 25 namespace base {
27 class ListValue; 26 class ListValue;
28 class TimeTicks; 27 class TimeTicks;
29 } 28 }
30 29
31 namespace IPC { 30 namespace IPC {
32 class Message; 31 class Message;
33 } 32 }
(...skipping 15 matching lines...) Expand all
49 class SiteInstance; 48 class SiteInstance;
50 class WebContents; 49 class WebContents;
51 class WebContentsImpl; 50 class WebContentsImpl;
52 struct FileChooserParams; 51 struct FileChooserParams;
53 struct GlobalRequestID; 52 struct GlobalRequestID;
54 struct NativeWebKeyboardEvent; 53 struct NativeWebKeyboardEvent;
55 struct Referrer; 54 struct Referrer;
56 struct RendererPreferences; 55 struct RendererPreferences;
57 struct WebPreferences; 56 struct WebPreferences;
58 57
58 namespace mojom {
59 class CreateNewWindowParams;
60 }
61
59 // 62 //
60 // RenderViewHostDelegate 63 // RenderViewHostDelegate
61 // 64 //
62 // An interface implemented by an object interested in knowing about the state 65 // An interface implemented by an object interested in knowing about the state
63 // of the RenderViewHost. 66 // of the RenderViewHost.
64 // 67 //
65 // This interface currently encompasses every type of message that was 68 // This interface currently encompasses every type of message that was
66 // previously being sent by WebContents itself. Some of these notifications 69 // previously being sent by WebContents itself. Some of these notifications
67 // may not be relevant to all users of RenderViewHost and we should consider 70 // may not be relevant to all users of RenderViewHost and we should consider
68 // exposing a more generic Send function on RenderViewHost and a response 71 // exposing a more generic Send function on RenderViewHost and a response
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 // the Windows function which is actually a #define. 161 // the Windows function which is actually a #define.
159 // 162 //
160 // TODO(alexmos): This should be moved to RenderFrameHostDelegate, and the 163 // TODO(alexmos): This should be moved to RenderFrameHostDelegate, and the
161 // corresponding IPC message should be sent by the RenderFrame creating the 164 // corresponding IPC message should be sent by the RenderFrame creating the
162 // new window. 165 // new window.
163 virtual void CreateNewWindow( 166 virtual void CreateNewWindow(
164 SiteInstance* source_site_instance, 167 SiteInstance* source_site_instance,
165 int32_t route_id, 168 int32_t route_id,
166 int32_t main_frame_route_id, 169 int32_t main_frame_route_id,
167 int32_t main_frame_widget_route_id, 170 int32_t main_frame_widget_route_id,
168 const ViewHostMsg_CreateWindow_Params& params, 171 const mojom::CreateNewWindowParams& params,
169 SessionStorageNamespace* session_storage_namespace) {} 172 SessionStorageNamespace* session_storage_namespace) {}
170 173
171 // The page is trying to open a new widget (e.g. a select popup). The 174 // The page is trying to open a new widget (e.g. a select popup). The
172 // widget should be created associated with the given |route_id| in the 175 // widget should be created associated with the given |route_id| in the
173 // process |render_process_id|, but it should not be shown yet. That should 176 // process |render_process_id|, but it should not be shown yet. That should
174 // happen in response to ShowCreatedWidget. 177 // happen in response to ShowCreatedWidget.
175 // |popup_type| indicates if the widget is a popup and what kind of popup it 178 // |popup_type| indicates if the widget is a popup and what kind of popup it
176 // is (select, autofill...). 179 // is (select, autofill...).
177 virtual void CreateNewWidget(int32_t render_process_id, 180 virtual void CreateNewWidget(int32_t render_process_id,
178 int32_t route_id, 181 int32_t route_id,
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 // Desktop Site" feature. 240 // Desktop Site" feature.
238 virtual bool IsOverridingUserAgent(); 241 virtual bool IsOverridingUserAgent();
239 242
240 protected: 243 protected:
241 virtual ~RenderViewHostDelegate() {} 244 virtual ~RenderViewHostDelegate() {}
242 }; 245 };
243 246
244 } // namespace content 247 } // namespace content
245 248
246 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_ 249 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698