chrome/browser/resources/vr_shell/vr_shell_ui.html - Issue 2363553003: VrShell: implement insecure content warning display

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/vr_shell/vr_shell_ui.html

Issue 2363553003: VrShell: implement insecure content warning display (Closed)

Patch Set: Use CSS styling instead of inline styles Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/vr_shell/vr_shell_ui.css ('K') | « chrome/browser/resources/vr_shell/vr_shell_ui.css ('k') | chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc » ('j') | chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!--	1 <!--

2 Copyright 2016 The Chromium Authors. All rights reserved.	2 Copyright 2016 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file.	4 found in the LICENSE file.

5 -->	5 -->
	Dan Beam 2016/09/27 22:33:40 why is this comment here? this is not common for why is this comment here? this is not common for .html files and might mess with <!DOCTYPE html> (if it's not the first line)
6 <!DOCTYPE html>	6 <!DOCTYPE html>

7 <html>	7 <html>

8 <head>	8 <head>

9 <meta charset="utf-8">	9 <meta charset="utf-8">

10 <if expr="is_android or is_ios">	10 <if expr="is_android or is_ios">

11 <meta name="viewport" content="width=device-width, initial-scale=1.0,	11 <meta name="viewport" content="width=device-width, initial-scale=1.0,

12 maximum-scale=1.0, user-scalable=no">	12 maximum-scale=1.0, user-scalable=no">

13 <meta http-equiv="cache-control" content="no-cache">	13 <meta http-equiv="cache-control" content="no-cache">

14 <meta http-equiv="pragma" content="no-cache">	14 <meta http-equiv="pragma" content="no-cache">
	Dan Beam 2016/09/27 22:33:40 why are you setting this caching-related <meta> ta why are you setting this caching-related <meta> tags?
15 </if>	15 </if>

16 <title>Vr Shell UIs</title>	16 <title>Vr Shell UIs</title>

17 <link rel="stylesheet" href="vr_shell_ui.css">	17 <link rel="stylesheet" href="vr_shell_ui.css">
	Dan Beam 2016/09/27 22:33:40 can you pull in text_defaults.css or text_defaults can you pull in text_defaults.css or text_defaults_md.css (if material design) to use the same font as all other places in chrome?
18 </head>	18 </head>

19 <body>	19 <body>

	20 <!-- IDS_WEBSITE_SETTINGS_INSECURE_WEBVR_CONTENT_TRANSIENT message -->

	21 <div id="webvr-not-secure-transient" class="webvr-message-box"><div class="webvr -center"><span class="webvr-center">$i18n{insecureWebVrContentTransient}</span>< /div></div></body>
	Dan Beam 2016/09/27 22:33:40 we try to wrap at 80 columns in HTML as well we try to wrap at 80 columns in HTML as well
	22 <!-- IDS_WEBSITE_SETTINGS_INSECURE_WEBVR_CONTENT_PERMANENT message -->

	23 <div id="webvr-not-secure-permanent" class="webvr-message-box"><span class="webv r-center">ⓘ $i18n{insecureWebVrContentPermanent}</span></div>

20 </body>	24 </body>

21	25

22 <!-- Run script after creating body, to let it add its own elements. -->	26 <!-- Run script after creating body, to let it add its own elements. -->

23 <script src="vr_shell_ui.js"></script>	27 <script src="vr_shell_ui.js"></script>

24 </html>	28 </html>

OLD	NEW