Remove macCharCode from inspector code.

Remove macCharCode from inspector code.

Follow up to https://codereview.chromium.org/236403002/

BUG=362927
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171476

[jbroman, 2014-04-13 18:31:01]

macCharCode was a field on PlatformKeyboardEvent that was never read.

It looks like it is exposed in the dev tools protocol (though supplying it does
nothing).

I'm hoping it can also be removed there, but I don't know enough about the
inspector/dev tools to know if there are caveats. Please advise. :)

[pfeldman, 2014-04-14 13:05:31]

lgtm

[jbroman, 2014-04-14 13:50:02]

Alright, so it is correct to remove the field from Inspector-1.1.json as well as
protocol.json?

[pfeldman, 2014-04-14 13:59:09]

You don't have to do this, but if the compile-time chack fails - feel free to.
It is safe as long as the command (or entire domain) is marked as hidden.

[jbroman, 2014-04-14 14:03:51]

On 2014/04/14 13:59:09, pfeldman wrote:
> You don't have to do this, but if the compile-time chack fails - feel free to.
> It is safe as long as the command (or entire domain) is marked as hidden.

I haven't had any compile-time check failures.

It doesn't look like it is marked as hidden. Rather, upon further investigation
it seems documented:
https://developers.google.com/chrome-developer-tools/docs/protocol/tot/input

Since the field does nothing, I'd like to remove it, but I don't know whether
it's appropriate to remove it from the 1.1 protocol, or only from the
tip-of-tree protocol (and let the change get rolled into 1.2 or whatever the
next version is).

[pfeldman, 2014-04-14 15:29:32]

On 2014/04/14 14:03:51, jbroman wrote:
> On 2014/04/14 13:59:09, pfeldman wrote:
> > You don't have to do this, but if the compile-time chack fails - feel free
to.
> > It is safe as long as the command (or entire domain) is marked as hidden.
> 
> I haven't had any compile-time check failures.
> 
> It doesn't look like it is marked as hidden. Rather, upon further
investigation
> it seems documented:
> https://developers.google.com/chrome-developer-tools/docs/protocol/tot/input
> 

Oh.

> Since the field does nothing, I'd like to remove it, but I don't know whether
> it's appropriate to remove it from the 1.1 protocol, or only from the
> tip-of-tree protocol (and let the change get rolled into 1.2 or whatever the
> next version is).

Still, it is fine to remove if we admit that it was an noop. Go ahead.

[jbroman, 2014-04-14 15:33:40]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2014-04-14 15:33:53]

On 2014/04/14 15:29:32, pfeldman wrote:
> On 2014/04/14 14:03:51, jbroman wrote:
> > On 2014/04/14 13:59:09, pfeldman wrote:
> > > You don't have to do this, but if the compile-time chack fails - feel free
> to.
> > > It is safe as long as the command (or entire domain) is marked as hidden.
> > 
> > I haven't had any compile-time check failures.
> > 
> > It doesn't look like it is marked as hidden. Rather, upon further
> investigation
> > it seems documented:
> > https://developers.google.com/chrome-developer-tools/docs/protocol/tot/input
> > 
> 
> Oh.
> 
> > Since the field does nothing, I'd like to remove it, but I don't know
whether
> > it's appropriate to remove it from the 1.1 protocol, or only from the
> > tip-of-tree protocol (and let the change get rolled into 1.2 or whatever the
> > next version is).
> 
> Still, it is fine to remove if we admit that it was an noop. Go ahead.

Alright, thanks.

[commit-bot: I haz the power, 2014-04-14 15:33:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbroman@chromium.org/236353003/1

[commit-bot: I haz the power, 2014-04-14 15:44:16]

Change committed as 171476