Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2363503003: fix #27411, avoid capture for instance creation (Closed)

Created:
4 years, 3 months ago by Jennifer Messerly
Modified:
4 years, 3 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2 lines) Patch
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 1 chunk +29 lines, -2 lines 2 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
4 years, 3 months ago (2016-09-21 22:16:01 UTC) #2
Leaf
lgtm https://codereview.chromium.org/2363503003/diff/1/pkg/analyzer/lib/src/generated/static_type_analyzer.dart File pkg/analyzer/lib/src/generated/static_type_analyzer.dart (right): https://codereview.chromium.org/2363503003/diff/1/pkg/analyzer/lib/src/generated/static_type_analyzer.dart#newcode1611 pkg/analyzer/lib/src/generated/static_type_analyzer.dart:1611: // {variablesFresh/variables} they apply it. s/they/then/ ?
4 years, 3 months ago (2016-09-21 23:12:58 UTC) #3
Jennifer Messerly
Committed patchset #1 (id:1) manually as 738b4810524996b3528b3dd1f13b45e5825c33b2 (presubmit successful).
4 years, 3 months ago (2016-09-21 23:19:42 UTC) #5
Jennifer Messerly
4 years, 3 months ago (2016-09-21 23:19:55 UTC) #6
Message was sent while issue was closed.
Thanks!

https://codereview.chromium.org/2363503003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/static_type_analyzer.dart (right):

https://codereview.chromium.org/2363503003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/static_type_analyzer.dart:1611: //
{variablesFresh/variables} they apply it.
On 2016/09/21 23:12:58, Leaf wrote:
> s/they/then/ ?

Done.

Powered by Google App Engine
This is Rietveld 408576698