Chromium Code Reviews
DescriptionRevert of Ntp: restore scroll position. (patchset #9 id:160001 of https://codereview.chromium.org/2327083002/ )
Reason for revert:
Broke org.chromium.chrome.browser.ntp.NewTabPageTest.*
Original issue's description:
> Ntp: restore scroll position.
>
> * The scroll position is stored as extra data on the NavigationEntry.
> * The main use case handled is when the user clicks on a suggested
> article and then back to view more suggestions. Maintaining scroll position helps maintain context and flow here.
> * It is the RecyclerView Adapter position that is stored and restored, so if the device is rotated in the meantime, scroll restore will still present the same content as long as the underlying data has not changed.
> * Because the underlying data is subject to change a few times per day, the scroll position is not persisted. It would be confusing the restore to an old position that now shows different content.
>
> BUG=606356
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/22b18a9a6d4f421ddb6d4f74280a571bf7dca4f6
> Cr-Commit-Position: refs/heads/master@{#420075}
TBR=bauerb@chromium.org,tedchoc@chromium.org,clamy@chromium.org,mvanouwerkerk@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=606356
Committed: https://crrev.com/651d3cce5637e5b1875468534b66325fc9f5dc92
Cr-Commit-Position: refs/heads/master@{#420146}
Patch Set 1 #Messages
Total messages: 6 (2 generated)
|