Generating autocomplete results with and without word breaks in the Omnibox.

Generating autocomplete results with and without word breaks in the Omnibox.

The goal is to support mid-word autocomplete in the Omnibox.  Currently, if the user types "funtimes", inserts the cursor between the "n" and the "t" and begins typing the word "good" the Ominbox will search for URL results that match "fungood times" only.  We want to also search for "fungoodtimes".

BUG=591979
TEST=0. Clear browser history.
1. Visit the following link: https://twitter.com/fungoodtimes
2. Open a new browser tab.
3.Type into the Omnibox "funtimes".  Note the lack of the suggestion for the above URL.
4. Insert the cursor between the "n" and "t" in "funtime" and type "good".
5. The above URL should show in the autocomplete list.

Committed: https://crrev.com/e3235816f23e9eb733d11bdecdfd5f8ca67cec9f
Cr-Commit-Position: refs/heads/master@{#418054}

patch from issue 2187343002 at patchset 240001 (http://crrev.com/2187343002#ps240001)

Reverting to previous working version of components/omnibox/browser/url_index_private_data.cc before resubmitting patch.


refactored URLIndexPrivateData::HistoryItemsForTerms

[Lavar Askew, 2016-09-21 20:09:48]

open.hyperion@gmail.com changed reviewers:
+ mpearson@chromium.org

[Lavar Askew, 2016-09-21 20:09:49]

Hi Mark,

can you please review the latest changes I have made?

Thanks,

Lavar

[Mark P, 2016-09-21 21:53:01]

lgtm (looks good to me)

Some questions though:
Do you want to revert the original patch to submit this?  (That's what the diff
currently shows.)
If so, then
  - do you want me to revert it or will you do it yourself? (I'm not sure if you
have permission to click the box)
  - you should add the AUTHORS change and the unit test change to this
changelist
If not, then
  - please upload a new version of this patchset that shows the appropriate diff
against the current tree

--mark

[Lavar Askew, 2016-09-22 15:03:33]

Yes, can you please revert the original patch?  From there I will make the
AUTHORS and unit test change and resubmit.

[Lavar Askew, 2016-09-23 01:44:45]

Patchset #3 (id:40001) has been deleted

[Mark P, 2016-09-23 04:02:45]

On 2016/09/22 15:03:33, Lavar Askew wrote:
> Yes, can you please revert the original patch?  From there I will make the
> AUTHORS and unit test change and resubmit.

The original patch set has been reverted.

This current change has been replaced by
https://codereview.chromium.org/2364553004/

I will mark this change as not submittable.

--mark

[Mark P, 2016-09-23 04:02:54]

not lgtm