Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 2363453002: Merge M54: Load live version when reloading an offline page on connected network (Closed)

Created:
4 years, 3 months ago by jianli
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Merge M54: Load live version when reloading an offline page on connected network In order to trigger reloading currently-displayed as offline page with network condition check, we resend the request with same extra request header with reason field updated. BUG=644943 Review-Url: https://codereview.chromium.org/2337363002 Cr-Commit-Position: refs/heads/master@{#419868} (cherry picked from commit f68c52f414b7b785720faf53458df2517e921c9e) Committed: https://chromium.googlesource.com/chromium/src/+/910386ff9b57445af8966322a34fe578dbba6681

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+537 lines, -165 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java View 3 chunks +14 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_bridge.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_bridge.cc View 2 chunks +29 lines, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_request_job.h View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_request_job.cc View 17 chunks +39 lines, -100 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_tab_helper.h View 4 chunks +38 lines, -14 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_tab_helper.cc View 5 chunks +55 lines, -19 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_utils.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_utils.cc View 2 chunks +26 lines, -1 line 0 comments Download
M components/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + components/offline_pages/request_header/BUILD.gn View 1 chunk +10 lines, -7 lines 0 comments Download
A components/offline_pages/request_header/offline_page_header.h View 1 chunk +80 lines, -0 lines 0 comments Download
A components/offline_pages/request_header/offline_page_header.cc View 1 chunk +132 lines, -0 lines 0 comments Download
A components/offline_pages/request_header/offline_page_header_unittest.cc View 1 chunk +82 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jianli
4 years, 3 months ago (2016-09-21 20:01:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
910386ff9b57445af8966322a34fe578dbba6681.

Powered by Google App Engine
This is Rietveld 408576698